Rewrite extract to user duplexer2

[ZJONSSON]

closes #98

Rewrite extract to user duplexer2 to separate the events of the inbound stream and outbound stream. This allows errors and finish events to be more controlled.

Add tests for broken zipfiles (see #98 (comment))

[ZJONSSON]

This will probably end up as a minor bump, not a patch, since the return object from Extract changes from Parser to duplex with Parser as the in-stream and Writable as the out-stream. The usable functions and events should still be exactly the same as before (i.e. events: close, finish, error and method .promise())

Unsure what to do with typescript definitions as "object types" are changed, even in a minor way
(see original PR DefinitelyTyped/DefinitelyTyped#22858 and current type definitions: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/c7004516e97da850d0872df71a0c326fc5e0581a/types/unzipper)

Is it better to actually include the types for the specific version in the unzipper package (and add "types": "unzipper.d.ts" to package.json)? If so I would love a PR that would demonstrate the ideal implemenation. Or should the DefinatelyTyped spec be updated to always represent the latest version of a library? I'm not a typescript user, but want to avoid breaking things for the typescript world.

cc @s73obrien @sabrehagen @MRayermannMSFT

[sabrehagen]

In my experience, packaging typescript types in your library can become a headache for both consumers and yourself if you're not a typescript developer. In DefinitelyTyped they require automated tests to ensure the typescript types match the exposed javascript interface. This shifts the responsibility to someone else, which can be a good or a bad thing, but I've found the DefinitelyTyped team to be very responsible with their management of PRs and type alterations. I'd personally publish them externally if this is not a typescript native library. ᐧ

…

On Wed, 22 May 2019 at 01:39, Ziggy Jonsson ***@***.***> wrote: This will probably end up as a minor bump, not a patch, since the return object from Extract changes from Parser to duplex with Parser as the in-stream and Writable as the out-stream. The usable functions and events should still be exactly the same as before (i.e. events: close, finish, error and method .promise()) Unsure what to do with typescript definitions as "object types" are changed, even in a minor way (see original PR DefinitelyTyped/DefinitelyTyped#22858 <DefinitelyTyped/DefinitelyTyped#22858> and current type definitions: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/c7004516e97da850d0872df71a0c326fc5e0581a/types/unzipper ) Is it better to actually include the types for the specific version in the unzipper package (and add "types": "unzipper.d.ts" to package.json)? If so I would love a PR that would demonstrate the ideal implemenation. Or should the DefinatelyTyped spec be updated to always represent the latest version of a library? I'm not a typescript user, but want to avoid breaking things for the typescript world. cc @s73obrien <https://github.com/s73obrien> @sabrehagen <https://github.com/sabrehagen> @MRayermannMSFT <https://github.com/MRayermannMSFT> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#128?email_source=notifications&email_token=AAILHSDVCRB5OITQG2R652LPWQJUHA5CNFSM4HOKOFEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV4KEJI#issuecomment-494445093>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAILHSBMUNLARUV62RAAL6LPWQJUHANCNFSM4HOKOFEA> .

[ZJONSSON]

Thanks @sabrehagen - merging to master. Will publish a minor bump when crx lands