Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed usage of zfcuser_login_form service in ZfcUserLoginWidget view helper #610

Merged
merged 1 commit into from
Dec 15, 2015

Conversation

nepda
Copy link
Contributor

@nepda nepda commented Dec 14, 2015

You moved 'zfcuser_login_form' to form_elements. In ZfcUserLoginWidget there was an old reference to the old location. This PR will fix this.

@basz
Copy link
Contributor

basz commented Dec 15, 2015

this issue would suggest a speedy 1.4.1 release, please

Danielss89 added a commit that referenced this pull request Dec 15, 2015
Fixed usage of zfcuser_login_form service in ZfcUserLoginWidget view helper
@Danielss89 Danielss89 merged commit e755d96 into ZF-Commons:1.x Dec 15, 2015
@Danielss89
Copy link
Member

Released 1.4.1, thx!

@nepda
Copy link
Contributor Author

nepda commented Dec 15, 2015

You're welcome! Now, I've discovered an similar bug according to the zfcuser_register_form. In src/ZfcUser/Service/User.php:207, It's easy to fix, but there is a test... and I'm unfortunately not a good test writer. tests/ZfcUserTest/Service/UserTest.php:479. I don't know how to mock this. I think the test will still be passing (if untouched) but this would be a false positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants