Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PHP 8.0 error ("" < -1) as there is no automatic cast anymore Syn… #102

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ralfbecker
Copy link
Contributor

…cObject->Check(): Unmet condition in object from type SyncProvisioning: parameter maxattsize is LOWER than -1. Check failed!

Released under the GNU Affero General Public License (AGPL), version 3

What does this implement/fix? Explain your changes.

It restores the previous PHP versions behavior, that ("" < -1) === false, by an explicit cast to (float)

Does this close any currently open issues?

...

Any relevant logs, error output, etc?

Unmet condition in object from type SyncProvisioning: parameter maxattsize is LOWER than -1. Check failed!

Where has this been tested?

Server (please complete the following information):

  • OS: iOS and Android
  • PHP Version: 8.4
  • Backend for: EGroupware using diffbackend
  • and Version: Z-Push version 2.5.0

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Mail App [e.g. GMail, Apple Mail]
  • Version [e.g. 22]

…cObject->Check(): Unmet condition in object from type SyncProvisioning: parameter maxattsize is LOWER than -1. Check failed!
@matidau
Copy link
Collaborator

matidau commented Aug 19, 2024

Thanks 🙂

@matidau matidau merged commit 871ddc6 into Z-Hub:develop Aug 19, 2024
2 checks passed
matidau added a commit that referenced this pull request Nov 27, 2024
fix PHP 8.0 error ("" < -1) as there is no automatic cast anymore Syn…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants