Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish v14 #97

Merged
merged 11 commits into from
Sep 2, 2019
Merged

Publish v14 #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b182f3c
Add method LDAPCPConfig.CreateDefaultConfiguration
Yvand Jul 8, 2019
596c376
Update method LDAPCPConfig.CreateDefaultConfiguration
Yvand Jul 8, 2019
024cd32
Simplify method LDAPCPConfig.ApplyConfiguration
Yvand Jul 9, 2019
e876494
Update LDAPCPConfig.cs
Yvand Jul 11, 2019
a52aaaf
Use helper SPClaimTypes.Equals when possible
Yvand Jul 18, 2019
653e1d9
Investigating issue https://github.com/Yvand/LDAPCP/issues/87
Yvand Jul 18, 2019
8b024e2
Test workaround to bug https://github.com/Yvand/LDAPCP/issues/87
Yvand Aug 6, 2019
c7daef4
Fixing https://github.com/Yvand/LDAPCP/issues/87
Yvand Aug 20, 2019
a5c1646
Fix https://github.com/Yvand/LDAPCP/issues/87
Yvand Aug 20, 2019
dee7f5e
Fix for bug https://github.com/Yvand/LDAPCP/issues/87 in scenario whe…
Yvand Aug 20, 2019
112ac3e
Update CHANGELOG.md
Yvand Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change log for LDAPCP

## Unreleased

* Add method LDAPCPConfig.CreateDefaultConfiguration
* Fix bug: randomly, LDAPCP returned results that were missing their domain name. In SharePoint logs, a DirectoryServicesCOMException error was recorded. https://github.com/Yvand/LDAPCP/issues/87

## LDAPCP 13.0.20190621.905 enhancements & bug-fixes - Published in June 21, 2019

* Add a default mapping to populate the email of groups
Expand Down
2 changes: 1 addition & 1 deletion LDAPCP.Tests/UnitTestsHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
[SetUpFixture]
public class UnitTestsHelper
{
public static readonly ldapcp.LDAPCP ClaimsProvider = new ldapcp.LDAPCP(UnitTestsHelper.ClaimsProviderName);
public static string ClaimsProviderName => "LDAPCP";
public static readonly ldapcp.LDAPCP ClaimsProvider = new ldapcp.LDAPCP(UnitTestsHelper.ClaimsProviderName);
public static readonly string ClaimsProviderConfigName = TestContext.Parameters["ClaimsProviderConfigName"];
public static Uri TestSiteCollUri;
public static readonly string TestSiteRelativePath = $"/sites/{TestContext.Parameters["TestSiteCollectionName"]}";
Expand Down
15 changes: 7 additions & 8 deletions LDAPCP/Features/LDAPCP/LDAPCP.EventReceiver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,14 @@ private void ExecBaseFeatureActivated(SPFeatureReceiverProperties properties)
{
ClaimsProviderLogging svc = ClaimsProviderLogging.Local;
ClaimsProviderLogging.Log($"[{LDAPCP._ProviderInternalName}] Activating farm-scoped feature for claims provider \"{LDAPCP._ProviderInternalName}\"", TraceSeverity.High, EventSeverity.Information, ClaimsProviderLogging.TraceCategory.Configuration);

var spTrust = LDAPCP.GetSPTrustAssociatedWithCP(LDAPCP._ProviderInternalName);
if (spTrust != null)
LDAPCPConfig existingConfig = LDAPCPConfig.GetConfiguration(ClaimsProviderConstants.CONFIG_NAME);
if (existingConfig == null)
{
LDAPCPConfig.CreateDefaultConfiguration();
}
else
{
LDAPCPConfig existingConfig = LDAPCPConfig.GetConfiguration(ClaimsProviderConstants.CONFIG_NAME);
if (existingConfig == null)
LDAPCPConfig.CreateConfiguration(ClaimsProviderConstants.CONFIG_ID, ClaimsProviderConstants.CONFIG_NAME, spTrust.Name);
else
ClaimsProviderLogging.Log($"[{LDAPCP._ProviderInternalName}] Use configuration \"{ClaimsProviderConstants.CONFIG_NAME}\" found in the configuration database", TraceSeverity.High, EventSeverity.Information, ClaimsProviderLogging.TraceCategory.Configuration);
ClaimsProviderLogging.Log($"[{LDAPCP._ProviderInternalName}] Use configuration \"{existingConfig.Name}\" found in the configuration database", TraceSeverity.High, EventSeverity.Information, ClaimsProviderLogging.TraceCategory.Configuration);
}
}
catch (Exception ex)
Expand Down
Loading