Ignore case when comparing claim types #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Yvand
commented
Apr 8, 2024
•
Yvand
commented
- Fix error when creating the configuration, due to case-sensitive test in the claim types - LDAPCPSE An item with LDAP newAttribute 'userPrincipalName' and LDAP class 'user' already exists for the object type 'User' #204
Yvand
added a commit
that referenced
this pull request
May 13, 2024
* Update AssemblyInfo.cs * Update GlobalSettings.ascx * Update GlobalSettings.ascx * Fix error if group claim type does not exist in the trust (#207) * fix #203 * Update CHANGELOG.md * update test in GroupIdentifierEncodedValuePrefix * delete group claim type if None is selected * Ignore case when comparing claim types (#205) * ignore case when comparing claim types * Update CHANGELOG.md * Update CHANGELOG.md * add server-side member NoValueSelected to test "None" * Add property max search results count (#211) * initial work * work * Fix uninitialized properties (#212) * Update LDAPProviderConfiguration.cs * remove deprecated pipelines * test if ClaimsPrincipal.Identity is null * Add helper methods to get/delete a directory connection in the configuration * ask for confirmation before deleting connection * fix repository name hosting the reusable workflows * update build workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.