-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating dialogTitle prop to be a string or element #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @4-Eyes ,
Thanks for your contribution and sorry for the delayed answer.
I added some comments and I'd ask you to also update TS typings to match the changes.
Apologies for the slow response. I believe I've addressed all your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@4-Eyes , thanks for your contribution, now it looks good but unfortunately GitHub says I cannot merge it because of conflicts, can you please rebase your changes (only the revenant ones) onto master
and update this PR?
Thanks again
@panz3r the PR should be updated now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
Type of change
How Has This Been Tested
DropzoneDialogBase
an example that includes a custom dialog title with an 'x' button for closing the dialog.Test Configuration:
Checklist