-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set initial files with File or URL string #194
Conversation
Hi @isaacbuckman , Thanks for your contribution, I'd try to avoid such a breaking change and instead prefer to add a condition on the I'd make the prop accept both |
Hey @panz3r, I agree that the breaking change is probably unnecessary for now. Maybe it is something we can do in the future. I updated the files so the change is no longer breaking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of changes to the typings and it's good for me.
P.S. Can you please do a git rebase
after the changes to keep only the required commits (you can remove all the commits up to and including the Revert
one)?
919eae6
to
c9b489a
Compare
@panz3r Removed the old commits so we should be good now. |
LGTM 👍 Thanks again for your contribution!
|
Description
File[]
string[]
) to initialFileURLsType of change
File[]
instead ofstring[]
Test Configuration: