-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Upgrade react-dropzone to version 10 #120
Conversation
… 'react' and 'material-ui' versions
@Yuvaleros can you look into this? Actually, @panz3r is bringing a lot of movement into this library and it could use a bit of love. |
Hi @Yuvaleros , Thanks for inviting me as a Collaborator to this project, I'll try my best to keep this project as updated as possibile. I recently merged my previous PR #119 , bumped the version number and made a tag ( I'll also merge this PR soon and then proceed to rebase all my other PRs. |
Hi @panz3r , Thanks for all the help and effort, I really appreciate it! I published a version today to NPM - 2.5.0, with various merged PR's. Is it possible to change the tag to 2.6.0 and I'll release another one? |
Hi @Yuvaleros ,
Of course, actually I just created the
|
You can publish version I'd wait to release version |
@panz3r , Reviewed and merged the relevant PR. Great stuff! Maybe we should add a few lines to the README warning that react versions lower than 16.8 are no longer supported and that version 2.x.x should be used, WDYT? |
Yeah, I think it's a great idea, I'd add a support table like this
|
As suggested I added the above |
This PR upgrade
react-dropzone
to version10.2.1
and updates the implementation to match the new component usage.This PR introduce a breaking change since
react-dropzone
v10+ dropped support forreact
versions older than v16.8
(see release notes here).Also this PR drops support for
material-ui
version3
.I'd suggest this to be a
major
version bump formaterial-ui-dropzone
(so bump to version3.0.0
) and, if support for older versions ofreact
andmaterial-ui
is still required, you can think to keep av2
branch with the previous implementation so that users of this library can decide to usev2.x
orv3.x
based on their needs whilst keep them updated independently (I think that many features/fixes can be ported from one version to the other with little to no effort).