Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Upgrade react-dropzone to version 10 #120

Merged
merged 2 commits into from
Apr 15, 2020
Merged

[BREAKING] Upgrade react-dropzone to version 10 #120

merged 2 commits into from
Apr 15, 2020

Conversation

panz3r
Copy link
Contributor

@panz3r panz3r commented Mar 18, 2020

This PR upgrade react-dropzone to version 10.2.1 and updates the implementation to match the new component usage.

This PR introduce a breaking change since react-dropzone v10+ dropped support for react versions older than v16.8 (see release notes here).

Also this PR drops support for material-ui version 3.

I'd suggest this to be a major version bump for material-ui-dropzone (so bump to version 3.0.0) and, if support for older versions of react and material-ui is still required, you can think to keep a v2 branch with the previous implementation so that users of this library can decide to use v2.x or v3.x based on their needs whilst keep them updated independently (I think that many features/fixes can be ported from one version to the other with little to no effort).

@panz3r panz3r mentioned this pull request Mar 26, 2020
@eluchsinger
Copy link

@Yuvaleros can you look into this? Actually, @panz3r is bringing a lot of movement into this library and it could use a bit of love.

@panz3r
Copy link
Contributor Author

panz3r commented Apr 15, 2020

Hi @Yuvaleros ,

Thanks for inviting me as a Collaborator to this project, I'll try my best to keep this project as updated as possibile.

I recently merged my previous PR #119 , bumped the version number and made a tag (v.2.5.0) that can be released, that would be the latest version to support older react version (less than 16.8).

I'll also merge this PR soon and then proceed to rebase all my other PRs.

@panz3r panz3r self-assigned this Apr 15, 2020
@panz3r panz3r merged commit 39f76ab into Yuvaleros:master Apr 15, 2020
@panz3r panz3r deleted the react-dropzone-upgrade-v10 branch April 15, 2020 15:23
@Yuvaleros
Copy link
Owner

Hi @panz3r ,

Thanks for all the help and effort, I really appreciate it!

I published a version today to NPM - 2.5.0, with various merged PR's. Is it possible to change the tag to 2.6.0 and I'll release another one?

@panz3r
Copy link
Contributor Author

panz3r commented Apr 15, 2020

Hi @Yuvaleros ,

I published a version today to NPM - 2.5.0, with various merged PR's. Is it possible to change the tag to 2.6.0 and I'll release another one?

Of course, actually I just created the v2.x branch to keep working on the backward-compatible version (the one based on [email protected]) and bumped the version to 2.5.1 (just a patch is enough for that)

master branch already contains the code based on [email protected] which is no longer compatible with react versions lower than 16.8 (which I marked as v3.0.0 😬 ).

@panz3r
Copy link
Contributor Author

panz3r commented Apr 15, 2020

@Yuvaleros ,

You can publish version 2.5.1 by checking out that branch.

I'd wait to release version 3.0.0 after merging PR #121 and maybe others as well.

@Yuvaleros
Copy link
Owner

@panz3r ,

Reviewed and merged the relevant PR. Great stuff!

Maybe we should add a few lines to the README warning that react versions lower than 16.8 are no longer supported and that version 2.x.x should be used, WDYT?

@panz3r
Copy link
Contributor Author

panz3r commented Apr 15, 2020

@Yuvaleros

Maybe we should add a few lines to the README warning that react versions lower than 16.8 are no longer supported and that version 2.x.x should be used, WDYT?

Yeah, I think it's a great idea, I'd add a support table like this

version react material-UI
3.x 16.8+ 4.x
2.x 15.x or 16.x 3.x or 4.x

@panz3r
Copy link
Contributor Author

panz3r commented Apr 16, 2020

@Yuvaleros ,

As suggested I added the above support table to both the README and the generated docsite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants