Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config panel #175

Merged
merged 21 commits into from
Nov 16, 2021
Merged

Config panel #175

merged 21 commits into from
Nov 16, 2021

Conversation

zamentur
Copy link
Member

@zamentur zamentur commented Sep 28, 2021

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@zamentur zamentur marked this pull request as draft September 28, 2021 15:11
@zamentur zamentur marked this pull request as ready for review September 29, 2021 00:43
@zamentur
Copy link
Member Author

Note one problem of this example is the comment are very verbose compared to the number of instructions...
What's your point of view ?

config_panel.toml.example Outdated Show resolved Hide resolved
config_panel.toml.example Outdated Show resolved Hide resolved
config_panel.toml.example Outdated Show resolved Hide resolved
config_panel.toml.example Outdated Show resolved Hide resolved
config_panel.toml.example Outdated Show resolved Hide resolved
config_panel.toml.example Outdated Show resolved Hide resolved
config_panel.toml.example Outdated Show resolved Hide resolved
config_panel.toml.example Outdated Show resolved Hide resolved
config_panel.toml.example Outdated Show resolved Hide resolved
bind = "name:/var/www/__APP__/settings.py"

## ---------------------------------------------------------------------
## IMPORTANT: other 'bind' mode exists:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should also explain the foo>bar:filename syntax

@zamentur zamentur merged commit 168d708 into master Nov 16, 2021
@alexAubin alexAubin deleted the config-panel branch November 16, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants