Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DownloadPageAPI to the autoupdater to download from HTML web pages #2041

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Add DownloadPageAPI to the autoupdater to download from HTML web pages #2041

merged 2 commits into from
Aug 28, 2024

Conversation

Salamandar
Copy link
Contributor

Tested with Jitsi and this configuration:

autoupdate.strategy = "latest_webpage_link"
autoupdate.upstream = "https://download.jitsi.org/stable/"
autoupdate.version_regex = "^jitsi-meet-web_([\\d\\.\\-]*)_all.deb$"

@orhtej2
Copy link
Contributor

orhtej2 commented Feb 20, 2024

I'm not saying it's a bad idea, I'm saying it's brittle as is web scraping in general 🤔

@Salamandar
Copy link
Contributor Author

The version_regex is matching against the link "content" (name ?).

@Salamandar
Copy link
Contributor Author

I'm not saying it's a bad idea, I'm saying it's brittle as is web scraping in general 🤔

Ah yes, agreed! But it's kind of an internal tool, if it breaks, no user will complain, so i'd say it's okay to have a not-really-hardened tool there.

@Salamandar Salamandar force-pushed the webpage_autoupdater branch 2 times, most recently from 1f65ac2 to 963fa16 Compare February 25, 2024 22:49
OniriCorpe
OniriCorpe approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@OniriCorpe OniriCorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this handy shit

@OniriCorpe OniriCorpe mentioned this pull request Mar 15, 2024
Open
@fflorent
Copy link
Contributor

FWIW, I would probably need that for elasticsearch8.

Psycojoker
Psycojoker previously requested changes Mar 22, 2024
View reviewed changes
tools/autoupdate_app_sources/rest_api.py Show resolved Hide resolved
@alexAubin
Copy link
Member

So ugh what's the status of this ?

@Salamandar Salamandar requested a review from Psycojoker August 28, 2024 19:03
@Salamandar Salamandar force-pushed the webpage_autoupdater branch 2 times, most recently from 96047d7 to 1d55524 Compare August 28, 2024 19:06
@Salamandar Salamandar enabled auto-merge (rebase) August 28, 2024 19:06
@Salamandar Salamandar force-pushed the webpage_autoupdater branch from 1d55524 to 8042d12 Compare August 28, 2024 19:07
@Salamandar Salamandar merged commit 9ed6ccc into YunoHost:master Aug 28, 2024
2 checks passed
@Salamandar Salamandar deleted the webpage_autoupdater branch August 28, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OniriCorpe OniriCorpe OniriCorpe approved these changes

@Psycojoker Psycojoker Awaiting requested review from Psycojoker

Assignees
No one assigned
Labels
inactive tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Salamandar @orhtej2 @fflorent @alexAubin @Psycojoker @OniriCorpe