Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing #54

Merged
merged 3 commits into from
Jul 7, 2018
Merged

Testing #54

merged 3 commits into from
Jul 7, 2018

Conversation

maniackcrudelis
Copy link
Contributor

@maniackcrudelis maniackcrudelis commented Jun 29, 2018 •
edited
Loading

Problem

Solution

  • Depend on YunoHost 2.7.12 and simplify change_url script
  • Clear assets cache after changing URL

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : frju365
  • Approval (LGTM) : frju365
  • Approval (LGTM) : Josué
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from a team June 29, 2018 18:32
@maniackcrudelis
Copy link
Contributor Author

Rewriting of the previous testing #52.
Sorry JimboJoe, I rewrote your commit, that was this branch which contains all the commits I was trying to get rid of.

@lapineige lapineige requested review from JimboJoe and lapineige June 29, 2018 19:01
@frju365
Copy link
Member

frju365 commented Jun 30, 2018

"!!! Timeout reached (180 min). !!!" mh... Is it the CI fault or something is wrong in change_url ?

frju365
frju365 approved these changes Jun 30, 2018
View reviewed changes
Copy link
Member

@frju365 frju365 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything seems to be fine.

@lapineige
Copy link
Member

Upgrading works. I have not tested a fresh install (yet).

@maniackcrudelis
Copy link
Contributor Author

Ready to be reviewed

@maniackcrudelis maniackcrudelis requested a review from a team July 3, 2018 12:23
@frju365
Copy link
Member

frju365 commented Jul 3, 2018

Will be merged in 3 days.

@maniackcrudelis maniackcrudelis merged commit 5ea515c into master Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josue-T Josue-T Josue-T approved these changes

@lapineige lapineige lapineige approved these changes

@frju365 frju365 frju365 approved these changes

@JimboJoe JimboJoe Awaiting requested review from JimboJoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maniackcrudelis @frju365 @lapineige @Josue-T