Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LDAP Support #17

Closed
wants to merge 47 commits into from
Closed

Add LDAP Support #17

wants to merge 47 commits into from

Conversation

liberodark
Copy link
Contributor

@liberodark liberodark commented Oct 22, 2019 •
edited by yalh76
Loading

Problem

  • No LDAP Support

Solution

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Package_check results

Build Status

yalh76 and others added 21 commits August 23, 2019 20:27
@liberodark
Copy link
Contributor Author

liberodark commented Oct 22, 2019 •
edited
Loading

Wait for add in master

@liberodark
Copy link
Contributor Author

liberodark commented Oct 22, 2019 •
edited
Loading

image
That is configuration for yunohost ldap support

@yalh76 yalh76 changed the base branch from master to testing October 22, 2019 18:15
@yalh76 yalh76 self-requested a review October 22, 2019 18:17
@yalh76 yalh76 self-assigned this Oct 22, 2019
@yalh76 yalh76 added the enhancement New feature or request label Oct 22, 2019
yalh76
yalh76 requested changes Oct 22, 2019
View reviewed changes
Copy link
Member

@yalh76 yalh76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. So cool.

I propose we wait the work you have done on dani-garcia/vaultwarden#677 to be merged and then we will use the next release of bitwarden_rs in app.src

@yalh76 yalh76 mentioned this pull request Oct 22, 2019
Open
@liberodark
Copy link
Contributor Author

This is in standby now

@liberodark liberodark closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yalh76 yalh76 yalh76 requested changes

Assignees

@yalh76 yalh76

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liberodark @yalh76