Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with synapse and synapse-coturn services not starting #458

Open
wants to merge 3 commits into
base: testing
Choose a base branch
from
Open

Fix issues with synapse and synapse-coturn services not starting #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db03b5c
Fix issue of coturn not starting on boot
May 3, 2024
cc6e455
Fix issue of synapse not starting on ipv4 only server
May 3, 2024
1f1a184
Change bind address from localhost to 127.0.0.1
May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conf/homeserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ listeners:
tls: false
type: http
x_forwarded: true
bind_addresses: ['::1', '127.0.0.1']
bind_addresses: [127.0.0.1]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of you remove ipv6 listening you also need to avoid that nginx try a ipv6 connection. So you also need explicitly set proxy pass to 127.0.0.1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially set this to localhost instead of 127.0.0.1, which would not break nginx config.
I need to find back the issue I'm kind of remembering about 127.0.0.1 working and localhost failing. Maybe it was not about listening on localhost but it was about connecting to localhost to another app that was listening on 127.0.0.1. Basically another app that is broken by the same thing you are telling that should not be done here.


resources:
- names: [client, federation]
Expand Down
2 changes: 1 addition & 1 deletion conf/synapse-coturn.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ User=turnserver
Group=turnserver
Type=notify
EnvironmentFile=/etc/matrix-__APP__/coturn_env
ExecStart=/usr/bin/turnserver -c /etc/matrix-__APP__/coturn.conf $EXTRA_OPTIONS --pidfile=
ExecStart=/usr/bin/turnserver -c /etc/matrix-__APP__/coturn.conf $EXTRA_OPTIONS -L 0.0.0.0 --pidfile=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really needed to bind to any public addresses?
this is not reverse proxied?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look like this is proxied. I do not find any reference to the port that is used (5351 in my case) in nginx config and the port is open on the firewall.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it looks like this is publicly available on purpose.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By this you remove the default value to listening on ipv4 and ipv6. So this will break instances with working ipv6.

Restart=on-failure
InaccessibleDirectories=/home
PrivateTmp=yes
Expand Down