Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to match the signal_ynh package #5

Merged
merged 12 commits into from
Mar 7, 2022

Conversation

nathanael-h
Copy link
Collaborator

@nathanael-h nathanael-h commented Nov 30, 2021

Problem

Solution

  • Update sha256 source sum
  • Changes to match the signal_ynh package

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Package_check results


Working time for this test: 2 minutes, 9 seconds (15:43:50)

 ============================================
 Tests summary
 ============================================


Package linter:                OK  (3 warnings, 7 possible improvements)
Install (nourl):               OK
Install (multi):               OK
Backup/restore:               fail
Upgrade:                      fail
Upgrade (01514cf0):           fail
Port already used:             OK

Level results
=============
Level 1 (Installable in at least one scenario)    OK
Level 2 (Installable in all scenarios)            OK
Level 3 (Can be upgraded)                        
Level 4 (Can be backup/restored)                 
Level 5 (No linter errors)                        ok 
Level 6 (App is in a community-operated git org)  ok 
Level 7 (Pass all tests + no linter warnings)    
Level 8 (Maintained and long-term good quality)  
Level 9 (Flagged high-quality in app catalog)    

Global level for this application: 2 (Installable in all scenarios)

Global working time for all tests: 12 minutes, 44 seconds (15:43:55)

Build Status

@nathanael-h nathanael-h changed the title Update sha256 source sum Changes to match the signal_ynh package Dec 1, 2021
@nathanael-h
Copy link
Collaborator Author

 ============================================
 Tests summary
 ============================================


Package linter:                OK  (2 warnings, 5 possible improvements)
Install (nourl):               OK
Install (multi):               OK
Backup/restore:               fail
Upgrade:                       OK
Upgrade (01514cf0):            OK
Port already used:             OK

Level results
=============
Level 1 (Installable in at least one scenario)    OK
Level 2 (Installable in all scenarios)            OK
Level 3 (Can be upgraded)                         OK
Level 4 (Can be backup/restored)                 
Level 5 (No linter errors)                        ok 
Level 6 (App is in a community-operated git org)  ok 
Level 7 (Pass all tests + no linter warnings)    
Level 8 (Maintained and long-term good quality)  
Level 9 (Flagged high-quality in app catalog)    

Global level for this application: 3 (Can be upgraded)

Global working time for all tests: 16 minutes, 34 seconds (23:56:05)

@nathanael-h
Copy link
Collaborator Author

Error in restore test is {Error: Unable to install synapse: An error occurred inside the app installation script
Info: The operation

Install the 'synapse' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20211202-112200-app_install-synapse' to get help
Warning: Here's an extract of the logs before the crash. It might help debugging the error:
Info: DEBUG - Dec 02 11:22:42 systemd[1]: nginx.service: Control process exited, code=exited, status=1/FAILURE
Info: DEBUG - Dec 02 11:22:42 systemd[1]: Reload failed for A high performance web server and a reverse proxy server.'
Info: DEBUG - + echo -e '[Error] Dec 02 11:21:54 systemd[1]: Starting A high performance web server and a reverse proxy server...
Info: DEBUG - Dec 02 11:21:54 systemd[1]: Started A high performance web server and a reverse proxy server.
Info: DEBUG - Dec 02 11:22:42 systemd[1]: Reloading A high performance web server and a reverse proxy server.
Info: DEBUG - Dec 02 11:22:42 nginx[10690]: nginx: [emerg] duplicate location "/.well-known/matrix/client" in /etc/nginx/conf.d/domain.tld.d/synapse_server_name.conf:7

Full log : https://paste.yunohost.org/anaqikovuy.coffeescript

install with the pre-installation of synapse.
@nathanael-h
Copy link
Collaborator Author

Packages-check on my computer seems to send false negative.
All defined tests:

 ============================================
 Tests summary
 ============================================


Package linter:                OK  (2 possible improvements)
Install (nourl):               OK
Install (multi):               OK
Backup/restore:                OK
Upgrade:                       OK
Upgrade (01514cf0):            OK
Port already used:            fail

Only install and port already used:

 ============================================
 Tests summary
 ============================================


Install (nourl):               OK
Port already used:             OK

@nathanael-h
Copy link
Collaborator Author

Can someone trigger the ci, or review, or test?

@nathanael-h
Copy link
Collaborator Author

Ohoh!! all check are ok 😃 🎆 🕺

 ============================================
 Tests summary
 ============================================


Package linter:                OK  (2 possible improvements)
Install (nourl):               OK
Install (multi):               OK
Backup/restore:                OK
Upgrade:                       OK
Upgrade (01514cf0):            OK
Port already used:             OK

Level results
=============
Level 1 (Installable in at least one scenario)    OK
Level 2 (Installable in all scenarios)            OK
Level 3 (Can be upgraded)                         OK
Level 4 (Can be backup/restored)                  OK
Level 5 (No linter errors)                       
Level 6 (App is in a community-operated git org)  ok 
Level 7 (Pass all tests + no linter warnings)    
Level 8 (Maintained and long-term good quality)  
Level 9 (Flagged high-quality in app catalog)    

Global level for this application: 4 (Can be backup/restored)

Global working time for all tests: 24 minutes, 36 seconds (19:03:27)
You can find the complete log of these tests in /home/...

@tituspijean
Copy link
Member

!testme

@yunohost-bot
Copy link

😜
Test Badge

Copy link
Member

@tituspijean tituspijean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but looks good to me. Maybe use the README generator as suggested by the linter. ;)

@tituspijean tituspijean requested a review from Gredin67 December 2, 2021 22:35
@nathanael-h
Copy link
Collaborator Author

I looked at the README generator, very nice tool 👍 I'll try it, maybe on another PR. I look forward to a review by Gredin67.

@nathanael-h
Copy link
Collaborator Author

Can someone merge?

@nathanael-h
Copy link
Collaborator Author

Maybe use the README generator as suggested by the linter. ;)
In another PR soon:tm: :wink:

@tituspijean tituspijean merged commit d38351f into YunoHost-Apps:testing Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants