Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 #93

Merged
merged 23 commits into from
Apr 27, 2023
Merged

Version 2 #93

merged 23 commits into from
Apr 27, 2023

Conversation

ericgaspar
Copy link
Member

Problem

  • Description of why you made this PR

Solution

  • And how do you fix that problem

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot

This comment was marked as outdated.

@orhtej2
Copy link
Contributor

orhtej2 commented Apr 4, 2023

I've pulled changes required for v0. 12 to #94, you're still lacking change in upgrade.

@tituspijean
Copy link
Member

@ericgaspar If that's alright I'll rebase the branch on the testing one with v0.12.0

@tituspijean
Copy link
Member

!testme

@yunohost-bot

This comment was marked as outdated.

@tituspijean
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

🎠
Test Badge

@tituspijean
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

🎠
Test Badge

@tituspijean
Copy link
Member

(to be restarted when YunoHost/yunohost#1637 is released)

manifest.toml Outdated Show resolved Hide resolved
@tituspijean
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

🌻
Test Badge

@ericgaspar ericgaspar requested a review from tituspijean April 27, 2023 07:34
manifest.toml Outdated
@@ -65,14 +65,14 @@ ram.runtime = "50M"
[resources.permissions]
main.url = "/"
main.show_tile = false
server_api.url = "__DOMAIN__/_matrix "
Copy link
Member

@tituspijean tituspijean Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericgaspar this one was pretty tricky to find out, as these spaces were breaking the path detection so all requests were going through the SSO (and triggering CORS issues).

@tituspijean tituspijean merged commit fc2cbb1 into testing Apr 27, 2023
@ericgaspar
Copy link
Member Author

@tituspijean why are we using

https://api.github.com/repos/matrix-org/dendrite/tarball/v0.12.0
over
https://github.com/matrix-org/dendrite/archive/refs/tags/v0.12.0.tar.gz

@ericgaspar ericgaspar deleted the version-2 branch April 28, 2023 07:40
@tituspijean
Copy link
Member

@tituspijean why are we using

https://api.github.com/repos/matrix-org/dendrite/tarball/v0.12.0
over
https://github.com/matrix-org/dendrite/archive/refs/tags/v0.12.0.tar.gz

I think that was the link I used for the auto-updater v1. If the new one uses the refs link, I'm fine with that. :)

@ericgaspar
Copy link
Member Author

ericgaspar commented Apr 28, 2023

ah ok. Let's see how the upgrade goes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants