-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2 #93
Version 2 #93
Conversation
!testme |
This comment was marked as outdated.
This comment was marked as outdated.
I've pulled changes required for v0. 12 to #94, you're still lacking change in |
@ericgaspar If that's alright I'll rebase the branch on the testing one with v0.12.0 |
!testme |
This comment was marked as outdated.
This comment was marked as outdated.
!testme |
!testme |
(to be restarted when YunoHost/yunohost#1637 is released) |
!testme |
manifest.toml
Outdated
@@ -65,14 +65,14 @@ ram.runtime = "50M" | |||
[resources.permissions] | |||
main.url = "/" | |||
main.show_tile = false | |||
server_api.url = "__DOMAIN__/_matrix " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericgaspar this one was pretty tricky to find out, as these spaces were breaking the path detection so all requests were going through the SSO (and triggering CORS issues).
@tituspijean why are we using
|
I think that was the link I used for the auto-updater v1. If the new one uses the |
ah ok. Let's see how the upgrade goes |
Problem
Solution
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)