Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend config panel and patch manifest #114

Merged
merged 34 commits into from
Sep 26, 2023
Merged

Extend config panel and patch manifest #114

merged 34 commits into from
Sep 26, 2023

Conversation

tituspijean
Copy link
Member

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

scripts/upgrade Outdated Show resolved Hide resolved
@tituspijean
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

Alrighty!
Test Badge

Copy link
Contributor

@Gredin67 Gredin67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some strange syntax that I don't know. Are these typos ?

scripts/upgrade Show resolved Hide resolved
scripts/upgrade Show resolved Hide resolved
scripts/upgrade Show resolved Hide resolved
@Gredin67
Copy link
Contributor

would be nice, and should be pretty quick to solve #108 to enable YunoHost-Apps/mautrix_signal_ynh#85

@Gredin67
Copy link
Contributor

image

woops, it looks like some special characters should be avoided in registration_shared_secret field. like # " '

Error: "500" Internal Server Error

Action: "PUT" /yunohost/api/apps/dendrite/config/main

Error message:
Could not read return from hook /etc/yunohost/apps/dendrite/scripts/config. Error: Corrupted YAML read from /tmp/tmp_w03oc0z/stdreturn (reason: while scanning a double-quoted scalar
in "", line 1, column 29:
registration_shared_secret: "D\#7m'YX'tI-]UQaU8poNZvQx@zCE-j,"
^
found unknown escape character '#'
in "", line 1, column 32:
registration_shared_secret: "D\#7m'YX'tI-]UQaU8poNZvQx@zCE-j,"
^). Raw content: registration_shared_secret: "D\#7m'YX'tI-]UQaU8poNZvQx@zCE-j,"
registration_disabled: "false"
disable_federation: "true"
enable_registration_captcha: "True"
guests_disabled: "False"

@tituspijean
Copy link
Member Author

I think # and ' do not need to be escaped, only the double quotes. :/

@tituspijean tituspijean merged commit 05760a8 into master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants