Preserve selection when changing collections #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpiechocki indeed I merged #249 first, I hadn't seen this one, my bad :) Could you check to fix the remaining conflict? You'll probably be faster than me. |
|
After a quick check, this should do the work, but please click through it before merging - It's been almost 3 months and I'm not 100% sure why this confilt happened :/ |
|
@mpiechocki thank you so much! Taking a look now :) |
|
Ok the single image selection was broken but it's an easy fix :) The selection preservation across folders is one of the big awaited features so thank you so much for tackling this 🍾 !!!! |
|
I'm glad I could help ;) happy new year! :) |
LucasDang
pushed a commit
to pukapp/secret-ios-YPImagePicker
that referenced
this pull request
Feb 10, 2022
Preserve selection when changing collections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to resolve #193
There will be a little refactor needed if #249 is merged first.
I'm not sure about one or two lines (you'll notice which ones, I guess ;p) but I couldn't find any bugs while testing it on a small example app.
This PR introduces a little change to the way selections are handled, so feel free to point out anything you think is not clear!