🚧 WIP

Yoii-Inc · Nov 7, 2023 · 1e1f0fd · 1e1f0fd
1 parent c4a3747
commit 1e1f0fd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/arkworks/algebra/poly/src/domain/mod.rs b/arkworks/algebra/poly/src/domain/mod.rs
@@ -34,18 +34,10 @@ pub trait EvaluationDomain<F: FftField>:
     type Elements: Iterator<Item = F> + Sized;
 
     /// Sample an element that is *not* in the domain.
-    fn sample_element_outside_domain<R: Rng>(&self, rng: &mut R, public_rng: bool) -> F {
-        let mut t = if public_rng {
-            F::pub_rand(rng)
-        } else {
-            F::rand(rng)
-        };
+    fn sample_element_outside_domain<R: Rng>(&self, rng: &mut R) -> F {
+        let mut t = F::rand(rng);
         while self.evaluate_vanishing_polynomial(t).is_zero() {
-            t = if public_rng {
-                F::pub_rand(rng)
-            } else {
-                F::rand(rng)
-            };
+            t = F::rand(rng);
         }
         t
     }

diff --git a/arkworks/groth16/src/generator.rs b/arkworks/groth16/src/generator.rs
@@ -77,7 +77,7 @@ where
 
     let domain_size = cs.num_constraints() + cs.num_instance_variables();
     let domain = D::new(domain_size).ok_or(SynthesisError::PolynomialDegreeTooLarge)?;
-    let t = domain.sample_element_outside_domain(rng, false);
+    let t = domain.sample_element_outside_domain(rng);
 
     end_timer!(domain_time);
     ///////////////////////////////////////////////////////////////////////////

diff --git a/arkworks/marlin/src/ahp/verifier.rs b/arkworks/marlin/src/ahp/verifier.rs
@@ -55,7 +55,7 @@ impl<F: PrimeField> AHPForR1CS<F> {
         let domain_k = GeneralEvaluationDomain::new(index_info.num_non_zero)
             .ok_or(SynthesisError::PolynomialDegreeTooLarge)?;
 
-        let alpha = domain_h.sample_element_outside_domain(rng, true);
+        let alpha = domain_h.sample_element_outside_domain(rng);
         let eta_a = F::rand(rng);
         let eta_b = F::rand(rng);
         let eta_c = F::rand(rng);
@@ -83,7 +83,7 @@ impl<F: PrimeField> AHPForR1CS<F> {
         mut state: VerifierState<F>,
         rng: &mut R,
     ) -> (VerifierSecondMsg<F>, VerifierState<F>) {
-        let beta = state.domain_h.sample_element_outside_domain(rng, true);
+        let beta = state.domain_h.sample_element_outside_domain(rng);
         let msg = VerifierSecondMsg { beta };
         state.second_round_msg = Some(msg);