Fix slack session when channel id is null #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw0517tw
reviewed
Jun 15, 2020
| promises.channelMembers = this._client.getAllConversationMembers( | ||
| channelId | ||
| ); | ||
| if (channelId != null) { |
There was a problem hiding this comment.
Suggested change
| if (channelId != null) { | |
| if (channelId) { |
etrex
changed the title
tw0517tw
reviewed
Jun 15, 2020
| const rawEvent = this._getRawEventFromRequest(body) as any; | ||
|
|
||
| // FIXME: define types for every slack events | ||
| getChannelId(rawEvent: any): string | null { |
There was a problem hiding this comment.
what will this method return if it's app home event?
Codecov Report
@@ Coverage Diff @@
## release/1.5 #802 +/- ##
===============================================
+ Coverage 81.08% 83.65% +2.56%
===============================================
Files 108 115 +7
Lines 4747 6068 +1321
Branches 1197 1491 +294
===============================================
+ Hits 3849 5076 +1227
- Misses 862 988 +126
+ Partials 36 4 -32
Continue to review full report at Codecov.
|
etrex
changed the title
tw0517tw
approved these changes
Jun 16, 2020
chentsulin
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
When user clicked a button on home tab, session key can't generate correctly.
spec
If the slack event is not related to any channel, then the session key set to the user id.