Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RequestContext): add id to RequestContext #774

Merged
merged 1 commit into from
May 20, 2020

Conversation

chentsulin
Copy link
Collaborator

Add the optional id property to the RequestContext type.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #774 into release/1.5 will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.5     #774   +/-   ##
============================================
  Coverage        81.07%   81.07%           
============================================
  Files              108      108           
  Lines             4741     4741           
  Branches          1195     1150   -45     
============================================
  Hits              3844     3844           
- Misses             862      869    +7     
+ Partials            35       28    -7     
Impacted Files Coverage Δ
packages/bottender/src/server/Server.ts 10.46% <0.00%> (ø)
packages/bottender/src/types.ts 100.00% <ø> (ø)
packages/bottender/src/chain.ts 76.92% <0.00%> (ø)
packages/bottender/src/getClient.ts 55.55% <0.00%> (ø)
packages/bottender/src/router/index.ts 90.66% <0.00%> (ø)
packages/create-bottender-app/src/shared/log.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117d40d...e619bc5. Read the comment docs.

@chentsulin chentsulin merged commit 05e9c35 into release/1.5 May 20, 2020
@chentsulin chentsulin deleted the add-req-id-to-requestContext branch May 20, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants