Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SessionStore): support custom session store #732

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

chentsulin
Copy link
Collaborator

@chentsulin chentsulin commented Apr 13, 2020

For example, use a user-defined string as driver:

const { MemorySessionStore } = require('bottender');

module.exports = {
  session: {
    driver: 'memory2',
    stores: {
      memory2: new MemorySessionStore();
    },
  },
};

#338

@chentsulin chentsulin requested a review from etrex April 13, 2020 09:31
@codecov-io
Copy link

codecov-io commented Apr 13, 2020

Codecov Report

Merging #732 into release/1.4 will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.4     #732      +/-   ##
===============================================
+ Coverage        81.21%   81.25%   +0.03%     
===============================================
  Files              108      108              
  Lines             4616     4619       +3     
  Branches          1162     1118      -44     
===============================================
+ Hits              3749     3753       +4     
- Misses             817      824       +7     
+ Partials            50       42       -8     
Impacted Files Coverage Δ
packages/bottender/src/types.ts 100.00% <ø> (ø)
packages/bottender/src/getSessionStore.ts 75.00% <100.00%> (+6.03%) ⬆️
packages/bottender/src/chain.ts 76.92% <0.00%> (ø)
packages/bottender/src/getClient.ts 55.55% <0.00%> (ø)
packages/bottender/src/router/index.ts 90.66% <0.00%> (ø)
packages/create-bottender-app/src/shared/log.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291ea13...c2debca. Read the comment docs.

@chentsulin chentsulin merged commit 1792773 into release/1.4 Apr 13, 2020
@chentsulin chentsulin deleted the support-customer-session-driver branch April 13, 2020 11:17
@chentsulin chentsulin mentioned this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants