Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type(withProps): improve types of withProps #731

Merged
merged 1 commit into from
Apr 13, 2020
Merged

type(withProps): improve types of withProps #731

merged 1 commit into from
Apr 13, 2020

Conversation

chentsulin
Copy link
Collaborator

@chentsulin chentsulin commented Apr 13, 2020 •
edited
Loading

Check if the action uses the provided props correctly:

import { withProps } from 'bottender';

function MyAction({ x }: { x: string }) {}

function App() {
  return withProps(MyAction, { x: 1 }); // fail
}

@chentsulin chentsulin requested a review from etrex April 13, 2020 07:07
@chentsulin chentsulin merged commit 2389706 into release/1.4 Apr 13, 2020
@chentsulin chentsulin deleted the improve-type-withProps branch April 13, 2020 11:17
@chentsulin chentsulin mentioned this pull request Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrex etrex etrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chentsulin @etrex