Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context): let getters return literal instead of string type #724

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

chentsulin
Copy link
Collaborator

This might improve some type checks.

@codecov-io
Copy link

Codecov Report

Merging #724 into release/1.4 will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.4     #724   +/-   ##
============================================
  Coverage        80.91%   80.91%           
============================================
  Files              108      108           
  Lines             4511     4511           
  Branches          1083     1127   +44     
============================================
  Hits              3650     3650           
+ Misses             815      808    -7     
- Partials            46       53    +7     
Impacted Files Coverage Δ
packages/bottender/src/line/LineContext.ts 71.95% <ø> (ø)
...ckages/bottender/src/messenger/MessengerContext.ts 96.99% <ø> (ø)
packages/bottender/src/slack/SlackContext.ts 86.20% <ø> (ø)
packages/bottender/src/telegram/TelegramContext.ts 53.08% <ø> (ø)
packages/bottender/src/viber/ViberContext.ts 92.85% <ø> (ø)
packages/bottender/src/whatsapp/WhatsappContext.ts 83.33% <ø> (ø)
packages/bottender/src/chain.ts 76.92% <0.00%> (ø)
packages/bottender/src/getClient.ts 55.55% <0.00%> (ø)
packages/bottender/src/router/index.ts 90.66% <0.00%> (ø)
packages/create-bottender-app/src/shared/log.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da26443...cdafd66. Read the comment docs.

@chentsulin chentsulin merged commit 0ebcb2c into release/1.4 Apr 8, 2020
@chentsulin chentsulin deleted the platform-instead-of-string branch April 8, 2020 12:26
@chentsulin chentsulin mentioned this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants