Fixes webhook verification with Micro when verifyToken is set in bot #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 90.01% 90.01%
=======================================
Files 107 107
Lines 3156 3156
Branches 748 748
=======================================
Hits 2841 2841
Misses 277 277
Partials 38 38
Continue to review full report at Codecov.
|
|
Nice PR. Thanks! |
chentsulin
pushed a commit
that referenced
this pull request
Apr 13, 2018
|
Released as v0.14.33 and v0.15.0-beta.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix of what seems to be a bug in the Micro webhook verification. This just brings it in line with what the code for the other web frameworks does.