-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows disabling individual AI buttons #21457
Conversation
Pull Request Test Coverage Report for Build 6ce43a3aa2278e335da8cccb15ff8d18a7df0e18Details
💛 - Coveralls |
@mhkuu Please be aware that following packages have been abandoned and are not actively maintained anymore:
Please consider using the other packages instead. |
Pull Request Test Coverage Report for Build c4942e241e7d3261899064d5ebe29ec602515b09Details
💛 - Coveralls |
packages/js/src/ai-assessment-fixes/components/ai-assessment-fixes-button.js
Outdated
Show resolved
Hide resolved
packages/js/src/ai-assessment-fixes/components/ai-assessment-fixes-button.js
Show resolved
Hide resolved
packages/js/src/ai-assessment-fixes/components/ai-assessment-fixes-button.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I propose to consider keeping the tooltip as it is and change the mouse event to a pointer event. And then handle the tooltip ariaLabel
with the disabled state of the button. Let me know if you need me to explain it 😄
Pull Request Test Coverage Report for Build db18fbd20f824f23ce6af4dc90fb85302ff82397Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
CR: Looks nice, definitely a nicer solution like this, closer to the original 😸 |
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
isEnabled
check.div
of theAIAssessmentFixesButton
because there are no mouse events when an element is disabled.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/wordpress-seo-premium/issues/4380