Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Yarn 4 #21345

Draft
wants to merge 47 commits into
base: trunk
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
02db423
Add Yarn 4
igorschoester Apr 26, 2024
cad79f2
Safe fix .gitignore
igorschoester Apr 26, 2024
7725d7c
Fix grunt clean
igorschoester Apr 26, 2024
552bba6
Refactor pretest to be part of test itself
igorschoester Apr 26, 2024
e8eb7f5
Fix analysis-report build and test
igorschoester Apr 26, 2024
89b88da
Fix browserslist-config lint
igorschoester Apr 26, 2024
5827801
Fix @yoast/components build:css and lint
igorschoester Apr 26, 2024
116d016
Fix @yoast/feature-flag lint and test
igorschoester Apr 26, 2024
18dea84
Fix @yoast/helpers lint and test
igorschoester Apr 26, 2024
b1437f8
Fix @yoast/wordpress-seo build and test commands
igorschoester Apr 26, 2024
212fd88
Fix @yoast/replacement-variable-editor test
igorschoester Apr 27, 2024
ebe5feb
Fix @yoast/search-metadata-previews test
igorschoester Apr 27, 2024
3371024
Fix @yoast/social-metadata-forms lint and test
igorschoester Apr 27, 2024
1a5477b
Fix @yoast/social-metadata-previews lint and test
igorschoester Apr 27, 2024
1a6fe8b
Change @yoast/ui-library scripts
igorschoester Apr 27, 2024
5838268
Expand yoastseo lint
igorschoester Apr 27, 2024
acc0e03
Fix root tooling lint
igorschoester Apr 27, 2024
ff381ff
Upgrade jest and cohorts
igorschoester Apr 27, 2024
57dd3c8
Update snapshots
igorschoester Apr 27, 2024
dd74b8f
Fix indexation component
igorschoester Apr 27, 2024
e11246c
Fix search test warning
igorschoester Apr 27, 2024
93a60a6
Clean Jest config
igorschoester Apr 27, 2024
cd60170
Specify lerna/nx task dependencies
igorschoester Apr 27, 2024
40c0aa7
Upgrade babel preset and cohorts
igorschoester Apr 27, 2024
7595c78
Bump CSS deps
igorschoester Apr 27, 2024
c49f9cf
Fix webpack deps
igorschoester Apr 27, 2024
6edbece
Fix style-guide deps
igorschoester Apr 27, 2024
b584fc8
Upgrade redux
igorschoester Apr 27, 2024
0827c7f
Fix react deps
igorschoester Apr 27, 2024
36fe11e
Add Grunt dev dep
igorschoester Apr 27, 2024
eb8169c
Allow semver control in sync WP dep script
igorschoester Apr 27, 2024
47f07db
Upgrade react-modal
igorschoester Apr 28, 2024
6c892c3
Remove unused react-intl and IntlProvider
igorschoester Apr 28, 2024
7c2ef1e
Remove react-aria-live
igorschoester Apr 28, 2024
3a49ac5
Upgrade WP blocks to WP 6.5 version
igorschoester Apr 28, 2024
bdfe6b0
Upgrade UI lib WP jest-preset-default
igorschoester Apr 28, 2024
92a41d2
Upgrade WP packages to their WP 6.5 version
igorschoester Apr 28, 2024
cfe2240
Clean jest-preset and configs
igorschoester Apr 28, 2024
8465d0e
Add missing react-is dep for styled-components
igorschoester Apr 28, 2024
4cf0c0d
Switch react and react-dom to actual deps
igorschoester Apr 28, 2024
4a3aa35
Add missing dev deps for Grunt
igorschoester Apr 28, 2024
8ae6c68
Remove jest version output from CI
igorschoester Apr 28, 2024
9442ede
Add Yarn constraints
igorschoester Oct 26, 2024
7961342
Fix Yarn constraints
igorschoester Oct 26, 2024
87c53b8
Yarn add constraint to enforce "workspace:^"
igorschoester Oct 26, 2024
ee2be17
Yarn add constraint to enforce consistent dependencies
igorschoester Oct 26, 2024
bd84f60
GH actions: add constraints step to JS lint
igorschoester Oct 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
artifact/
apps/
css/dist/
packages/
js/dist/
vendor/
Expand Down
55 changes: 0 additions & 55 deletions .eslintrc

This file was deleted.

15 changes: 15 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
module.exports = {
root: true,
"extends": [
"yoast",
],
parserOptions: {
ecmaVersion: 2018,
sourceType: "module",
},
settings: {
react: {
version: "detect",
},
},
};
19 changes: 11 additions & 8 deletions .github/workflows/jslint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,34 +11,34 @@ on:
- 'feature/**'
paths:
- '**.js' # Includes Gruntfile.js.
- '**.cjs'
- '.browserslistrc'
- '.eslintignore'
- '.eslintrc'
- '.nvmrc'
- '.yarnrc'
- '.yarnrc.yml'
- 'lerna.json'
- 'nx.json'
- 'package.json'
- 'yarn.lock'
- '.github/workflows/jslint.yml'
- '.yarn/**'
- 'apps/**'
- 'config/grunt/**'
- 'config/**/*.js'
- 'packages/**'
pull_request:
paths:
- '**.js' # Includes Gruntfile.js.
- '**.cjs'
- '.browserslistrc'
- '.eslintignore'
- '.eslintrc'
- '.nvmrc'
- '.yarnrc'
- '.yarnrc.yml'
- 'lerna.json'
- 'nx.json'
- 'package.json'
- 'yarn.lock'
- '.github/workflows/jslint.yml'
- '.yarn/**'
- 'apps/**'
- 'config/grunt/**'
- 'config/**/*.js'
- 'packages/**'
# Allow manually triggering the workflow.
workflow_dispatch:
Expand Down Expand Up @@ -82,3 +82,6 @@ jobs:

- name: Run Javascript lint
run: yarn lint

- name: Run Yarn constraints
run: yarn constraints
2 changes: 0 additions & 2 deletions .github/workflows/jstest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ jobs:
node --version
yarn --version
grunt --version
yarn run jest --version
- name: Build all packages
run: yarn run build --ignore "@yoast/wordpress-seo"
Expand Down Expand Up @@ -194,7 +193,6 @@ jobs:
node --version
yarn --version
grunt --version
yarn run jest --version
- name: Build all packages
if: ${{ steps.checks-run.outputs.should == 'true' }}
Expand Down
35 changes: 19 additions & 16 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ local.properties
.cproject
.buildpath
.vscode
.idea/
nbproject/
node_modules/
bower_components/
Expand All @@ -28,7 +29,6 @@ phpunit.xml
phpunit-integration.xml
phpunit-wp.xml
.phpunit.result.cache
build/

############
## OSes
Expand All @@ -37,6 +37,7 @@ build/
[Tt]humbs.db
[Dd]esktop.ini
*.DS_store
.DS_store
.DS_store?

############
Expand All @@ -45,6 +46,7 @@ build/

bin/
tmp/
/.tmp
*.tmp
*.bak
*.log
Expand All @@ -53,20 +55,32 @@ tmp/
*.cpr
*.orig
*.php.in
.idea/
temp/
._*
.Trashes
.env
.svn
.tmp
.cache/phpunit/cache/
.nx/cache

############
## Composer
############
/vendor/
/vendor_prefixed/

############
## Yarn
############
.pnp.*
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions
yarn-error.log

############
## WPSEO
############
Expand All @@ -88,25 +102,14 @@ test.sh
/premium/src/generated/

############
# Dist files
## Dist files
############
/languages/
/js/vendor/*
/js/dist/*
build/
/css/dist/*
/packages/*/dist
/blocks/**
yarn-error.log
coverage
dependencies.json
dependencies.md
.vscode
.idea/
.DS_Store

############
# Temp files
############
/.tmp

.cache/phpunit/cache/
Loading
Loading