Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate the Yoast SEO PHP files and directories instead of flushin… #20921

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Dec 7, 2023

Reverted by #21082

Context

  • We want to remove opcache reset.

Summary

This PR can be summarized in the following changelog entry:

  • We want to remove op-cache reset.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Install Yoast test helper

  • Clone op-cache gui to the public folder of your WordPress environment.

  • Go to http://wordpress.test/opcache-gui/ (with your site).

  • Enable real time update

  • Search for wordpress-seo

  • Check the results has no has been invalidated label.

  • Search for yoast-test-helper

  • Check the results are without has been invalidated label.

  • Go to Tools->Yoast Test

  • In section Plugin options & database versions change YoastSEO DB version to an older version

  • Save

  • Go to http://wordpress.test/opcache-gui/ (with your site).

  • Go to the Cached tab and go to the last possible page.

  • Scroll down and look for the has been invalidated label. as shown in the screenshot.
    image

  • Search for yoast-test-helper

  • Check the results has no has been invalidated label.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

  • QA can not test this PR directly.
  • QA needs to perform regression tests for upgrading from previous versions.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #20654

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Dec 7, 2023
wp-seo-main.php Outdated Show resolved Hide resolved
@thijsoo thijsoo added this to the 21.9 milestone Dec 15, 2023
Copy link
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo merged commit f93df30 into trunk Dec 15, 2023
22 checks passed
@thijsoo thijsoo deleted the improve-opcache-invalidation branch December 15, 2023 11:10
thijsoo added a commit that referenced this pull request Jan 24, 2024
Revert #20921 - Invalidate the Yoast SEO PHP files and directories instead of...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yoast updates delete opcache for non-Yoast and non-WordPress PHP files
3 participants