Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double-title elements when using a custom single-page block template #17585

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Avoid double-title elements when using a custom single-page block template #17585

merged 1 commit into from
Nov 24, 2021

Conversation

aristath
Copy link
Contributor

@aristath aristath commented Nov 2, 2021

Context

Backports changes from WordPress/gutenberg#36133

Summary

Removes the _block_template_render_title_tag hook

Test instructions

Steps to reproduce the issue available on WordPress/gutenberg#34106

Test instructions for QA when the code is in the RC

QA can test this PR by following these steps:

  • Create a new page. Add some content and save.
  • On the sidebar of the post, select to create a new template for the post.
  • Save the template
  • Visit the frontend and check the page source

There should only be a single <title> element in the <head> of the document. Needs to be tested both with Gutenberg active, and inactive.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects other environments and needs to be tested there.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.

Fixes #

@aristath aristath requested a review from herregroen November 2, 2021 09:40
@herregroen herregroen added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 24, 2021
@herregroen herregroen added this to the 17.8 milestone Nov 24, 2021
@herregroen herregroen merged commit c2889ee into trunk Nov 24, 2021
@herregroen herregroen deleted the backport/gutenberg-36133 branch November 24, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herregroen herregroen herregroen approved these changes

Assignees
No one assigned
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Milestone
17.8
Development

Successfully merging this pull request may close these issues.
2 participants
@aristath @herregroen