Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implemented PHPStan level 8, introduced some DTO classes to prevent some multidimensional array shapes, introduced BackendUserTrait and LanguageServiceTrait #580

Merged

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Sep 26, 2024

This PR is set to the feature/13-compatibility branch, but first the pipeline should succeed before merging.

Summary

This PR can be summarized in the following changelog entry:

  • Bugfixes for the TYPO3 13.3 release
    • Added check for the autogenerated columns in the TCA of tx_yoastseo_related_focuskeyword to not get included in 13
    • Fixed the layout / templates for the backend modules
    • Fixed the styling for the dashboard widgets
  • Implemented phpstan level 8
    • A lot of (return) types, especially array shapes, have been added
    • Some c
  • Introduced new structure for the DataProviders for the Overview backend module
    • Instead of registering it through the EXTCONF they are configured within Services.yaml
    • New methods have been added to OverviewDataProviderInterface to return the values that were previously in the array
    • New DataProviderRequest added which is created in the OverviewController and then passed to the data provider through a new initialize method (replaces the previous callerParams functionality)
  • LanguageMenuFactory has been added to move the code from the OverviewController
  • Added a BackendUserTrait and LanguageServiceTrait to remove duplicate code

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Riny van Tiggelen added 2 commits September 25, 2024 19:38
… prevent some multidimensional array shapes, introduced BackendUserTrait and LanguageServiceTrait
…les, added condition for tx_yoastseo_related_focuskeyword to not include auto generated columns in 13
@RinyVT RinyVT merged commit 3286702 into feature/13-compatibility Sep 26, 2024
9 checks passed
@RinyVT RinyVT deleted the feature/functional-unit-acceptance-testing branch September 26, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant