Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Prevent undefined array key warning #566

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

peterkraume
Copy link
Contributor

Fixes: #565

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

@RinyVT
Copy link
Collaborator

RinyVT commented Dec 11, 2023

Thanks for the PR! I've changed the code a bit by using !isset and ?? to make it a bit more readable and we do not need the null checks that array_key_exists provides, do you agree?

@peterkraume
Copy link
Contributor Author

I'm perfectly fine with your changes. Thx for taking care!

@RinyVT RinyVT merged commit 200fd73 into Yoast:main Dec 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log flodded with PHP Warnings: Undefined array key "df"
2 participants