Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Use websiteTitle of site configuration for snippet preview #564

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

RinyVT
Copy link
Collaborator

@RinyVT RinyVT commented Nov 8, 2023

Summary

This PR can be summarized in the following changelog entry:

  • Defining the website title within the snippet preview previously was only taken from websiteTitle of a site's language, now also the global websiteTitle is taken into account

Relevant technical choices:

  • Site attribute is taken from TYPO3_REQUEST and the websiteTitle is retrieved from getConfiguration just like in core

Test instructions

This PR can be tested by following these steps:

  • Pull branch
  • Set websiteTitle within the site configuration
  • Check a (sub) page of the site and start typing in the seo_title field, the website title should now stay in place

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #549

@RinyVT RinyVT merged commit 77b5100 into main Nov 21, 2023
9 checks passed
@RinyVT RinyVT deleted the bugfix/549-website-title branch November 21, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview does not show website title from siteconfig
1 participant