Merge pull request #189 from Yoast/feature/2.x/add-attributes-for-ann…

…otations 2.x | Tests: add attributes for annotations
Yoast · Sep 6, 2024 · eb2db84 · eb2db84
2 parents da0bf11 + 5cecae1
commit eb2db84
Show file tree

Hide file tree

Showing 41 changed files with 209 additions and 0 deletions.
diff --git a/src/TestCases/XTestCase.php b/src/TestCases/XTestCase.php
@@ -2,6 +2,10 @@
 
 namespace Yoast\PHPUnitPolyfills\TestCases;
 
+use PHPUnit\Framework\Attributes\After;
+use PHPUnit\Framework\Attributes\AfterClass;
+use PHPUnit\Framework\Attributes\Before;
+use PHPUnit\Framework\Attributes\BeforeClass;
 use PHPUnit\Framework\TestCase as PHPUnit_TestCase;
 use Yoast\PHPUnitPolyfills\Helpers\AssertAttributeHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
@@ -55,6 +59,7 @@ abstract class XTestCase extends PHPUnit_TestCase {
 	 *
 	 * @return void
 	 */
+	#[BeforeClass]
 	public static function setUpFixturesBeforeClass() {
 		parent::setUpBeforeClass();
 	}
@@ -68,6 +73,7 @@ public static function setUpFixturesBeforeClass() {
 	 *
 	 * @return void
 	 */
+	#[Before]
 	protected function setUpFixtures() {
 		parent::setUp();
 	}
@@ -81,6 +87,7 @@ protected function setUpFixtures() {
 	 *
 	 * @return void
 	 */
+	#[After]
 	protected function tearDownFixtures() {
 		parent::tearDown();
 	}
@@ -94,6 +101,7 @@ protected function tearDownFixtures() {
 	 *
 	 * @return void
 	 */
+	#[AfterClass]
 	public static function tearDownFixturesAfterClass() {
 		parent::tearDownAfterClass();
 	}

diff --git a/tests/Exceptions/InvalidComparisonMethodExceptionTest.php b/tests/Exceptions/InvalidComparisonMethodExceptionTest.php
@@ -2,6 +2,7 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Exceptions;
 
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;
 use Yoast\PHPUnitPolyfills\Exceptions\InvalidComparisonMethodException;
 
@@ -10,6 +11,7 @@
  *
  * @covers \Yoast\PHPUnitPolyfills\Exceptions\InvalidComparisonMethodException
  */
+#[CoversClass( InvalidComparisonMethodException::class )]
 final class InvalidComparisonMethodExceptionTest extends TestCase {
 
 	/**

diff --git a/tests/Helpers/AssertAttributesHelperTest.php b/tests/Helpers/AssertAttributesHelperTest.php
@@ -2,7 +2,9 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Helpers;
 
+use PHPUnit\Framework\Attributes\CoversClass;
 use ReflectionException;
+use Yoast\PHPUnitPolyfills\Helpers\AssertAttributeHelper;
 use Yoast\PHPUnitPolyfills\TestCases\TestCase;
 use Yoast\PHPUnitPolyfills\Tests\Helpers\Fixtures\ClassWithProperties;
 
@@ -11,6 +13,7 @@
  *
  * @covers \Yoast\PHPUnitPolyfills\Helpers\AssertAttributeHelper
  */
+#[CoversClass( AssertAttributeHelper::class )]
 final class AssertAttributesHelperTest extends TestCase {
 
 	/**

diff --git a/tests/Polyfills/AssertClosedResourceBzip2Test.php b/tests/Polyfills/AssertClosedResourceBzip2Test.php
@@ -2,6 +2,9 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -15,6 +18,9 @@
  *
  * @requires extension bz2
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
+#[RequiresPhpExtension( 'bz2' )]
 final class AssertClosedResourceBzip2Test extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceCurlTest.php b/tests/Polyfills/AssertClosedResourceCurlTest.php
@@ -2,6 +2,10 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresPhp;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -19,6 +23,10 @@
  * @requires extension curl
  * @requires PHP < 8.0
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
+#[RequiresPhp( '< 8.0' )]
+#[RequiresPhpExtension( 'curl' )]
 final class AssertClosedResourceCurlTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceDirTest.php b/tests/Polyfills/AssertClosedResourceDirTest.php
@@ -2,6 +2,8 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -13,6 +15,8 @@
  * @covers \Yoast\PHPUnitPolyfills\Helpers\ResourceHelper
  * @covers \Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
 final class AssertClosedResourceDirTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceEnchantTest.php b/tests/Polyfills/AssertClosedResourceEnchantTest.php
@@ -2,6 +2,10 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresPhp;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -22,6 +26,10 @@
  * @phpcs:disable Generic.PHP.DeprecatedFunctions.Deprecated
  * @phpcs:disable PHPCompatibility.FunctionUse.RemovedFunctions.enchant_broker_freeDeprecated
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
+#[RequiresPhp( '< 8.0' )]
+#[RequiresPhpExtension( 'enchant' )]
 final class AssertClosedResourceEnchantTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceFileTest.php b/tests/Polyfills/AssertClosedResourceFileTest.php
@@ -2,6 +2,8 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -13,6 +15,8 @@
  * @covers \Yoast\PHPUnitPolyfills\Helpers\ResourceHelper
  * @covers \Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
 final class AssertClosedResourceFileTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceFinfoTest.php b/tests/Polyfills/AssertClosedResourceFinfoTest.php
@@ -2,6 +2,10 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresPhp;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -19,6 +23,10 @@
  * @requires extension finfo
  * @requires PHP < 8.1
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
+#[RequiresPhp( '< 8.1' )]
+#[RequiresPhpExtension( 'finfo' )]
 final class AssertClosedResourceFinfoTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceGdTest.php b/tests/Polyfills/AssertClosedResourceGdTest.php
@@ -2,6 +2,10 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresPhp;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -19,6 +23,10 @@
  * @requires extension gd
  * @requires PHP < 8.0
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
+#[RequiresPhp( '< 8.0' )]
+#[RequiresPhpExtension( 'gd' )]
 final class AssertClosedResourceGdTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceNotResourceTest.php b/tests/Polyfills/AssertClosedResourceNotResourceTest.php
@@ -3,9 +3,12 @@
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
 use PHPUnit\Framework\AssertionFailedError;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use PHPUnit_Framework_AssertionFailedError;
 use stdClass;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 use Yoast\PHPUnitPolyfills\Polyfills\ExpectExceptionMessageMatches;
 
@@ -15,6 +18,8 @@
  * @covers \Yoast\PHPUnitPolyfills\Helpers\ResourceHelper
  * @covers \Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
 final class AssertClosedResourceNotResourceTest extends TestCase {
 
 	use AssertClosedResource;
@@ -30,6 +35,7 @@ final class AssertClosedResourceNotResourceTest extends TestCase {
 	 *
 	 * @return void
 	 */
+	#[DataProvider( 'dataNotResource' )]
 	public function testAssertIsClosedResource( $value ) {
 		$pattern = '`^Failed asserting that .+? is of type ["]?resource \(closed\)["]?`s';
 
@@ -64,6 +70,7 @@ public function testAssertIsClosedResourceFailsWithCustomMessage() {
 	 *
 	 * @return void
 	 */
+	#[DataProvider( 'dataNotResource' )]
 	public function testAssertIsNotClosedResource( $value ) {
 		self::assertIsNotClosedResource( $value );
 	}
@@ -95,6 +102,7 @@ public function testAssertIsNotClosedResourceFailsWithCustomMessage() {
 	 *
 	 * @return void
 	 */
+	#[DataProvider( 'dataNotResource' )]
 	public function testShouldClosedResourceAssertionBeSkipped( $value ) {
 		$this->assertFalse( self::shouldClosedResourceAssertionBeSkipped( $value ) );
 	}

diff --git a/tests/Polyfills/AssertClosedResourceProcessTest.php b/tests/Polyfills/AssertClosedResourceProcessTest.php
@@ -2,6 +2,8 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -13,6 +15,8 @@
  * @covers \Yoast\PHPUnitPolyfills\Helpers\ResourceHelper
  * @covers \Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
 final class AssertClosedResourceProcessTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceShmopTest.php b/tests/Polyfills/AssertClosedResourceShmopTest.php
@@ -2,6 +2,10 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\Before;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -24,6 +28,9 @@
  * @phpcs:disable Generic.PHP.DeprecatedFunctions.Deprecated
  * @phpcs:disable PHPCompatibility.FunctionUse.RemovedFunctions.shmop_closeDeprecated
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
+#[RequiresPhpExtension( 'shmop' )]
 final class AssertClosedResourceShmopTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;
@@ -38,6 +45,7 @@ final class AssertClosedResourceShmopTest extends AssertClosedResourceTestCase {
 	 *
 	 * @return void
 	 */
+	#[Before]
 	protected function skipOnIncompatiblePHP() {
 		if ( \PHP_VERSION_ID < 70000 || \PHP_VERSION_ID >= 80000 ) {
 			$this->markTestSkipped( 'This test requires PHP 7.x.' );

diff --git a/tests/Polyfills/AssertClosedResourceWddxTest.php b/tests/Polyfills/AssertClosedResourceWddxTest.php
@@ -2,6 +2,10 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresPhp;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -22,6 +26,10 @@
  * @phpcs:disable PHPCompatibility.FunctionUse.RemovedFunctions.wddx_packet_startRemoved
  * @phpcs:disable PHPCompatibility.FunctionUse.RemovedFunctions.wddx_packet_endRemoved
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
+#[RequiresPhp( '< 7.4' )]
+#[RequiresPhpExtension( 'wddx' )]
 final class AssertClosedResourceWddxTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceXmlParserTest.php b/tests/Polyfills/AssertClosedResourceXmlParserTest.php
@@ -2,6 +2,9 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresPhp;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
 use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
@@ -20,6 +23,10 @@
  * @requires extension libxml
  * @requires PHP < 8.0
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
+#[RequiresPhp( '< 8.0' )]
+#[RequiresPhpExtension( 'libxml' )]
 final class AssertClosedResourceXmlParserTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceZipTest.php b/tests/Polyfills/AssertClosedResourceZipTest.php
@@ -2,6 +2,9 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -23,6 +26,9 @@
  * @phpcs:disable PHPCompatibility.FunctionUse.RemovedFunctions.zip_closeDeprecated
  * @phpcs:disable WordPress.PHP.NoSilencedErrors.Discouraged
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
+#[RequiresPhpExtension( 'zip' )]
 final class AssertClosedResourceZipTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;

diff --git a/tests/Polyfills/AssertClosedResourceZlibTest.php b/tests/Polyfills/AssertClosedResourceZlibTest.php
@@ -2,6 +2,9 @@
 
 namespace Yoast\PHPUnitPolyfills\Tests\Polyfills;
 
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\RequiresPhpExtension;
+use Yoast\PHPUnitPolyfills\Helpers\ResourceHelper;
 use Yoast\PHPUnitPolyfills\Polyfills\AssertClosedResource;
 
 /**
@@ -15,6 +18,9 @@
  *
  * @requires extension zlib
  */
+#[CoversClass( AssertClosedResource::class )]
+#[CoversClass( ResourceHelper::class )]
+#[RequiresPhpExtension( 'zlib' )]
 final class AssertClosedResourceZlibTest extends AssertClosedResourceTestCase {
 
 	use AssertClosedResource;