Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support slice() #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

hotoo
Copy link

@hotoo hotoo commented May 5, 2019

No description provided.

@coveralls
Copy link

coveralls commented May 5, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 8a2ef27 on hotoo:feat/slice into 57a487e on YingshanDeng:master.

Copy link
Owner

@YingshanDeng YingshanDeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi,添加 slice 方法的作用是?会不会和 substring 重复了呢?

@hotoo
Copy link
Author

hotoo commented May 18, 2019

这个 PR 主要将 emojicharstring 升级为高阶的 String 类,修正了原生 String 类针对部分 Unicode 的 length 等相关属性和方法的处理错误。
而 slice 是 String 的一个普通方法,但是处理 Emoji 这些特殊 Unicode 字符有误,所以也需要复写处理。

@YingshanDeng
Copy link
Owner

感觉不是很妥当,新增的方法中,有BUG。
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants