Clean-up code before initial release

[KatarzynaUlichnowska]

When looking at the code, I see many pieces of code that are never used, that are redundant, or legacies from previous versions.
I would urge to take the time to go through the whole code and remove any bits that are not in use. This will a) make the code easier to understand, b) reduce the probability of bugs, and c) make the code easier to develop further.
This also means remove any "hacks" / special cases that have been build into the code. It will be worth the effort in the medium term.

[KatarzynaUlichnowska]

comment from Maik:
+1
found a lot of data in the language files which seems to be double or not used.
I expect the same in the program files

[KatarzynaUlichnowska]

Comment from YetiForce:
Yes, you are right, we have to go through the code and organize it. We are planning to do it, but currently our priority is to fix bugs (in programming and logics). When a stable version is out, then we will focus on the code. If you have any suggestions or examples regarding where and what should be improved or removed, then we are eager to see your recommendations.

[KatarzynaUlichnowska]

Comment from Maik:

Examples:
languages/en_us/Vtiger.php and languages/en_us/Settings/Vtiger.php
These files seems to be the catch basin for all definitions that someone needed fast.
very long and some definitions are for modules.
it is better when all modules have their own def files within the language system.
also I would expect that die Settings/viger.php will be responsible for the settings in yetiforce.
but some definitions from the Settings are in the first vtiger and vice versa.
it is mixed what is used.
so, a clear definition where to find what will be good.

[bpabiszczak]

Just the way you suggested, in the first instance we will clear the code and fix strange errors, for example the ones we can see here:

https://insight.sensiolabs.com/projects/0c22cf68-8b4c-4587-a14c-c4c93f241760/analyses/2

When we fix most of them, then we will publish a stable version.