Merge. #1
Merged
Merge. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1244ada7297d2f6f567d679452d21a26b91c0360
Change-Id: Icb6a8ac2d92a38190fbc89d88a0a97120646f843
Change-Id: I8fff2322e3b3feb6e80cfc2be1d5743e9ec9bbb7
This reverts commit 62ef2cd.
…017 environment build job Author: Max Risuhin <[email protected]> Closes #870 from MaxRis/ARROW-1241 and squashes the following commits: a3ba6b0 [Max Risuhin] ARROW-1241: [C++] Appveyor build matrix extended with Visual Studio 2017 environment build job
….2.3 This PR supercedes #871 (repo fork for that one was deleted) Author: Matt Darwin <(none)> Closes #879 from mattdarwin/ARROW-1240-upgrade-logback and squashes the following commits: caed163 [Matt Darwin] upgrading slf4j to 1.7.25
The changes here expose the ability to set "lastSet" on Nullable<var length>Vector. I believe this is needed only for NullableVarCharVector and NullableVarBinaryVector. Hence the API is exposed through NullableValueVectors.java Author: siddharth <[email protected]> Closes #868 from siddharthteotia/ARROW-1237 and squashes the following commits: 786dfea [siddharth] ARROW-1237: addressed review comments and added more tests 73b2fc5 [siddharth] ARROW-1237: added some unit tests f8c7277 [siddharth] ARROW-1237: expose the ability to set lastSet
Currently used version of the git-commit-id-plugin maven plugin (2.1.9) doesn't work with recent git structures. This is for majority of the users not manifested since Arrow has the java maven root in the project subdirectory (`/java`) instead of top level so this plugin normally doesn't kick in if maven is executed from the subdirectory (usual case - ie `cd java; mvn install` - works fine) as the plugin doesn't see the `.git` directory but it does kick in and fail if executed from the main arrow top level dir as `mvn -f java/pom.xml install` (where the `.git` sits): ``` $ mvn -f java/pom.xml package ... [ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.1.9:revision (for-jars) on project arrow-java-root: Execution for-jars of goal pl.project13.maven:git-commit-id-plugin:2.1.9:revision failed: Bare Repository has neither a working tree, nor an index -> [Help 1] ``` Simple fix is upgrading the plugin to recent version (the minimal working version appears to be 2.1.13). This is required for seamless integration with Jenkins (ARROW-1234). Author: Antony Mayi <[email protected]> Closes #869 from antonymayi/master and squashes the following commits: 6976ee0 [Antony Mayi] ARROW-1239 - upgrading git-commit-id-plugin
This PR introduces a Cython API to Plasma, a FindPlasma.cmake to make it easier to integrate Plasma with CMake projects and sets up packaging with pyarrow. Author: Philipp Moritz <[email protected]> Author: Robert Nishihara <[email protected]> Closes #797 from pcmoritz/plasma-cython and squashes the following commits: d8319fc [Philipp Moritz] get for of PlasmaClient.connect d14ab87 [Philipp Moritz] get rid of MutableBuffer 08f24a5 [Philipp Moritz] fix typos and move FixedSizeBufferOutputStream e33443d [Philipp Moritz] fix setup.py develop for plasma 5f7b779 [Philipp Moritz] changes needed to make Ray work with Plasma in Arrow b9e2dee [Philipp Moritz] fix windows build 3e4a84d [Philipp Moritz] fix segfault 0bea267 [Philipp Moritz] debug 23fe5f5 [Philipp Moritz] make plasma store binary part of the pyarrow package for tests b863d13 [Philipp Moritz] fix 997de1e [Philipp Moritz] fix 47dc739 [Philipp Moritz] fixes 47033e7 [Philipp Moritz] switch to pytest ed84c53 [Philipp Moritz] partial fixes 9bc5c15 [Philipp Moritz] implement wait and fetch for the client 45f338f [Philipp Moritz] test plasma on macOS 8b53618 [Philipp Moritz] fix 54f595e [Philipp Moritz] try fixing python 2 tests 2c6d652 [Philipp Moritz] convert docs to numpy format 3270628 [Philipp Moritz] try to get documentation up 44d1a55 [Philipp Moritz] cleanups and release GIL a9f6502 [Philipp Moritz] more fixes 1ff88e7 [Philipp Moritz] fix travix ci 348f9bf [Philipp Moritz] fixes 4ae1a27 [Philipp Moritz] fix fd80203 [Philipp Moritz] Plasma Python extension packaging: It compiles! 3b69973 [Robert Nishihara] Fixed minor python linting. c9f6bcf [Robert Nishihara] Fix indentation and line lengths in plasma.pyx. 67b0951 [Robert Nishihara] Fix long lines in plasma/test/test.py. e26527c [Robert Nishihara] Convert plasma test.py from 2 space indentation to 4 space indentation. acc71d2 [Philipp Moritz] add round trip test for dataframes 2b7f949 [Philipp Moritz] implement mutable arrow python buffers c06f1b5 [Philipp Moritz] fix test 1d7928f [Philipp Moritz] add arrow roundtrip test 6371e2e [Philipp Moritz] fix tests 3021d59 [Philipp Moritz] make ObjectID pickleable dd5a7d8 [Philipp Moritz] fix tests 777e9c7 [Philipp Moritz] introduce plasma namespace a4a9628 [Philipp Moritz] fix c++ tests 924888b [Philipp Moritz] update f970df3 [Philipp Moritz] reduce logging 2ff2480 [Philipp Moritz] workaround for python visibility d4934a9 [Philipp Moritz] update cba92c1 [Philipp Moritz] setup.py for plasma 066d0ea [Philipp Moritz] test 1aea320 [Philipp Moritz] run plasma tests 3c4de52 [Philipp Moritz] use cmake to build the cython extension bf39297 [Philipp Moritz] build and install pyarrow for plasma tests 5bf722a [Philipp Moritz] fix plasma path 1c5434c [Philipp Moritz] fix formatting 187cc24 [Philipp Moritz] add travis tests c3d462d [Philipp Moritz] remove Python C extension d9261b4 [Philipp Moritz] add documentation and license db2d09a [Philipp Moritz] get all python tests in place 78d08ac [Philipp Moritz] make eviction work in Cython 18e0ac4 [Philipp Moritz] get tests bc681ca [Philipp Moritz] port some python tests f8e05f2 [Philipp Moritz] implement plasma.get in the cython client d590c8a [Philipp Moritz] update 5178ee7 [Philipp Moritz] update 9044a01 [Philipp Moritz] initial plasma cython client commit
… sizes on Windows Author: Max Risuhin <[email protected]> Closes #877 from MaxRis/ARROW-1195 and squashes the following commits: 675d584 [Max Risuhin] ARROW-1195: [C++] CpuInfo init with cores number, frequency and cache sizes on Windows
…ectors This will allow us to do some cleanup in Dremio where we have written wrapper routines using Reflection to access the fillEmpties method of mutator. Unit tests have been added. Author: siddharth <[email protected]> Closes #880 from siddharthteotia/ARROW-1249 and squashes the following commits: e0532c5 [siddharth] Merge branch 'ARROW-1249' of https://github.com/siddharthteotia/arrow into ARROW-1249 dc05206 [siddharth] ARROW-1249: Expose fillEmpties() from Nullable Variable Length Vectors f24d8f1 [siddharth] ARROW-1249: expose fillEmpties from Nullable variable length vectors
Author: Philipp Moritz <[email protected]> Closes #882 from pcmoritz/plasma-test-speedup and squashes the following commits: 09ffbdf [Philipp Moritz] speed up plasma tests
JavaTester was commented out, probably accidentally from a previous commit, this re-enables it. Author: Bryan Cutler <[email protected]> Closes #875 from BryanCutler/enable-java-integration-ARROW-1245 and squashes the following commits: c08c6e2 [Bryan Cutler] enabled JavaTester in integration tests
Author: Wes McKinney <[email protected]> Closes #876 from wesm/ARROW-1246 and squashes the following commits: 98790df [Wes McKinney] Review feedback to clarify nullability of map components 346b48d [Wes McKinney] Typo 06ae8eb [Wes McKinney] Draft Flatbuffer metadata for Map
Author: Philipp Moritz <[email protected]> Closes #883 from pcmoritz/plasma-client-connect and squashes the following commits: 667629f [Philipp Moritz] cleanup 886beab [Philipp Moritz] create factory method for connecting to the plasma client 09ffbdf [Philipp Moritz] speed up plasma tests
Our coding style guide has a ton of rules. I put up this patch to discuss since we don't have too many patches outstanding right now. This uses the exact Google style used in TensorFlow and other projects, but relaxes the column limit to 90 characters.
The main change is horizontal alignment in function signatures:
```diff
void ValidateBasicStructArray(const StructArray* result,
- const vector<uint8_t>& struct_is_valid, const vector<char>& list_values,
- const vector<uint8_t>& list_is_valid, const vector<int>& list_lengths,
- const vector<int>& list_offsets, const vector<int32_t>& int_values) {
+ const vector<uint8_t>& struct_is_valid,
+ const vector<char>& list_values,
+ const vector<uint8_t>& list_is_valid,
+ const vector<int>& list_lengths,
+ const vector<int>& list_offsets,
+ const vector<int32_t>& int_values) {
```
I find the paren-aligned version a bit more readable, but it's a matter of taste
Author: Wes McKinney <[email protected]>
Closes #848 from wesm/google-style and squashes the following commits:
9e8fe4f [Wes McKinney] Move import to platform.h
8690257 [Wes McKinney] Use Google C++ code formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.