Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seaborn 0.9 compatibility #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacobkimmel
Copy link

@jacobkimmel jacobkimmel commented Oct 26, 2018

Adds compatibility with new seaborn color palettes introduced in 0.9.

Since the colors are explicitly unpacked into individual variables, anyone running 0.9 gets a ValueError with the existing code.

Adds compatibility with new `seaborn` color plots introduced in `0.9`.
@boblannon
Copy link

just hit this bug as well, and the fix looks right to me. if the project doesn't intend to support seaborn==0.9, i think it should at least peg to an appropriate version in the requirements file.

@zhaoni153
Copy link

Dear authors, can you post a working packages version numbers for those in requirement.txt? Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants