Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datalake-486 avoid log creds #3

Merged
merged 1 commit into from
May 10, 2018
Merged

datalake-486 avoid log creds #3

merged 1 commit into from
May 10, 2018

Conversation

dichiarafrancesco
Copy link

Avoid logging creds. log sql query statement only

@smoy
Copy link

smoy commented May 9, 2018

LGTM, ship-it. (this one is somewhat meta, not sure how to write unit test for it)

@smoy smoy closed this May 9, 2018
@smoy smoy reopened this May 9, 2018
smoy
smoy approved these changes May 9, 2018
View reviewed changes
Copy link

@smoy smoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship-it (is it too meta to write a unit test for this?)

@dichiarafrancesco dichiarafrancesco merged commit 967dddb into master May 10, 2018
sungjuly added a commit to sungjuly/spark-redshift that referenced this pull request Jan 31, 2019
@sungjuly
Cherry picking from Yelp changes
3b6a318 
* Yelp#5
* Yelp#4
* Yelp#3
* Yelp#2
* Yelp#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoy smoy smoy approved these changes

@angelolicastro angelolicastro Awaiting requested review from angelolicastro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dichiarafrancesco @smoy