This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
Introducing users param in puppet-uchiwa #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'users' param in puppet-uchiwa allows to specify an array of user credentials to access the uchiwa dashboard. This effectively enables uchiwa to support multiple users rather than sharing the same username and password between multiple users. This feature has been introduced in Uchiwa 0.10.0
| # Array of hashes | ||
| # An array of user credentials to access the uchiwa dashboard. If set, it takes | ||
| # precendence over 'user' and 'pass'. | ||
| # Example: [{ |
There was a problem hiding this comment.
Can you expand this example to show both a rw and ro user and use markdown to make it easier to read? Also eventually the keys will need to be quoted as strings for future-parser compat. Here I think copy/paste this:
# Example:
# ```
# [{
# 'username' => 'rouser1',
# 'password' => 'pass1',
# 'readonly' => false,
# },
# {
# 'username' => 'rwuser1',
# 'password' => 'pass1',
# 'readonly => false,
# }]
# ```
#
There was a problem hiding this comment.
whoops, wrong readonly on the rw user, hopefully you get what I mean
There was a problem hiding this comment.
No problem @solarkennedy, hope it looks better to you now 😄
I have expanded the users parameter documentation, quoting the hash keys for future parser compatibility and rearranging the example hash with markdown notation.
|
Thanks! |
solarkennedy
added a commit
that referenced
this pull request
Dec 4, 2015
Introducing users param in puppet-uchiwa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new
usersfeature, introduced in uchiwa 0.10.0. This allows users to specify an array of credentials to access the uchiwa dashboard, rather than sharing the same set of keys.This PR also fixes #46