Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Signature should use timestamp flag #22

Closed
MTRNord opened this issue Feb 16, 2021 · 1 comment
Closed

[BUG] Signature should use timestamp flag #22

MTRNord opened this issue Feb 16, 2021 · 1 comment

Comments

@MTRNord
Copy link

MTRNord commented Feb 16, 2021

ℹ️ Info

Version: v0.1.12

💬 Description

Currently the sign function used doesnt add a timestamp. This especially is problematic when the certificate used for a specific sign process gets used after the cert was invalid. As it currently cant know when it was signed the binary/msix would show up as not validly signed anymore. However with a timestamp it can verify it is still valid.

Solution

The Code in question is https://github.com/YehudaKremer/msix/blob/main/lib/msix.dart#L169-L178

Adding /tr http://timestamp.digicert.com to that command is enough to solve this bug. If you want I will open a PR :)

YehudaKremer added a commit that referenced this issue Feb 17, 2021
@YehudaKremer
Copy link
Owner

Helllo Marcel :)

i added your code to the sign action: https://github.com/YehudaKremer/msix/blob/main/lib/msix.dart#L178-L179
now vailable in version: msix: ^0.1.13

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants