공통 프로필 및 토글 프로필 컴포넌트 제작 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test 코드에 png 이미지가 있을 경우 테스트가 안되는 이슈 발생
- [ ] 숫자 폰트 설정 필요
- [ ] 아이콘 컴포넌트 width, height 조절이 필요함
AppleSDGothicNeoEM00 to AppleSDGothicNeoM00
dididy
pushed a commit
that referenced
this pull request
Nov 12, 2020
- jestjs/jest#2663 (comment) - 테스트코드 일부 추가
- jestjs/jest#2663 (comment) - 테스트코드 일부 추가
- rebase를 이런식으로 하는게 맞는지 확실하지 않음(cherry-pick 사용) - 찬호님이 이슈 해결한 커밋 땡겨와서 적용 후 작업했음 - 프로필 이미지 경로 변경
|
음... cherry pick commit 을 해본적이 없어서 잘 모르겠네요..ㅠㅠ 항상 master에 rebase해서 사용했습니다ㅠㅠ --수정 cherry pick으로 제 #51의 commit부분을 당겨서 pull하신건가요? |
Lavegaa
approved these changes
Nov 20, 2020
|
|
||
| ProfileIcon.propTypes = { | ||
| src: PropTypes.string, | ||
| size: PropTypes.number, |
There was a problem hiding this comment.
size가 small로 들어오는데 숫자로 정의됐습니다. string으로 수정하면 좋을것같습니다.
There was a problem hiding this comment.
@Lavegaa boolean으로 구조를 변경해서 반영하였습니다!
|
|
||
| const profileImage = 'https://avatars2.githubusercontent.com/u/16266103?s=460&u=46ab2774d38212f0d0050592ce02dbcf36a7a97a&v=4'; | ||
|
|
||
| function renderProfileInfoContainer(name='홍길동', participateRate=90, src=profileImage) { |
There was a problem hiding this comment.
띄어쓰기가 lint에 잡혔습니다.
function renderProfileInfoContainer(name = '홍길동', participateRate = 90, src = profileImage) {다들 번거롭지만 소중한 lint화이팅 합시다...하나씩 잡고가기가 쉽지가 않네요ㅠㅠ
- ProfileInfoContainer.test.js에 띄어쓰기 제거
- 기존에 문자열을 넘기는 방식에서 isSmall이라는 boolean 값을 넘겨주도록 변경 - 연관된 컴포넌트 코드들에 반영
SkynI25
approved these changes
Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해결해야하는 추가 문제