-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted buildagent-generation-template.yml to work with new actions/running-images image directory structure. #71
Conversation
It seems in the meantime they also changed the folder structure for the release images: https://github.com/actions/runner-images/pull/8627/ |
That should mean than images created after November 15th have now a production status. Hopefully @YannickRe has time to merge my pull request, which should work with the new file structure. I have currently tested it in two enviroments. In both I was able to generate new Windows and Linux runner images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Erik, why did you keep an old file?
At first only the alpha version was using the new structure, but the pre-release and release were using the old structure. So we are in a transition fase. I have removed it now. |
The release version also uses the new structure. I'm trying your version and for now it works for ubuntu. I'll also try it for Windows. |
@erik-de-bont thank you for the work. Is there a specific reason you switched to using the build-image.ps1 and measure-provisioners-duration.ps1 from the runner-images repo and not the one included in this repo? |
@YannickRe No, there is no specific reason. I just looked at the action/runner-images code and modified the scripts to make it work again with the new action/runner-images code. |
Due to a change in the actions/runner-images repo, the templates have been changed from *.json to pkr.hcl format for the alpha releases.. At the moment of writing this comment the pre-release and release are still using the json format. It usually takes 2-4 weeks before the alpha images become release, so we are again in a transition period. |
@erik-de-bont thanks for all the work! I do not require more information, I have been working long hours to go-live with my project. Soon I'll take 4 weeks vacation, and your work is the highest on my list to get out the door. I'm sorry for the lack of interaction. |
@erik-de-bont I finally got around to testing and merging it today. Thank you for all the hard work! |
…running-images image directory structure. (YannickRe#71) * New Builagent yaml * move files for rebase * adjusted new template to runners * removed blank lines * Corrected variables * Corrected code format * corrected path * corrected syntax * correct source path scripts * added back #ResourceNamePrefix * Added Copy Image Artifacts task * adjusted param to var * added export var ResourcesNamePrefix * add var export ImageType * Correct isOutput=true * Correct missing var for sysprep patch * Correct var order * Correct typo * corrected typo * remove old file * adjust filepath to relative path * update template json to pkr.hcl
New build buildagent-generation-template.yml to solve issue l#70. During the transition period of the actions/runner-images repository of migrating to the new directory image structure the script can only be used for alpha images. The old script (renamed buildagent-generation-template-old ) should be use for pre-production and production image during this transition period.