Skip to content

Commit

Permalink
Merge pull request #11 from Yannic:delete_tests_for_deprecated_proto_…
Browse files Browse the repository at this point in the history
…source_root

GitOrigin-RevId: ed8be6d0d3c00b8896edc2b768c47cd51b267048
  • Loading branch information
autoyannic committed Jun 24, 2019
2 parents 43fda20 + cdbf214 commit a100e6e
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 215 deletions.
3 changes: 0 additions & 3 deletions proto/tests/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ proto_library(
"//proto/tests/dir:add_and_strip_prefix_import_proto",
"//proto/tests/dir:add_and_strip_prefix_proto",
"//proto/tests/dir:add_and_strip_prefix_subdir_proto",
"//proto/tests/dir:proto_source_root_import_proto",
"//proto/tests/dir:proto_source_root_proto",
"//proto/tests/dir:proto_source_root_without_dir_proto",
"//proto/tests/dir:strip_empty_prefix_proto",
"//proto/tests/dir:strip_empty_prefix_without_dir_proto",
"//proto/tests/dir:strip_prefix_import_proto",
Expand Down
71 changes: 0 additions & 71 deletions proto/tests/dir/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ proto_library(
"//proto/tests/dir:add_and_strip_empty_subdir_prefix_proto",
"//proto/tests/dir:add_and_strip_prefix_proto",
"//proto/tests/dir:add_and_strip_prefix_subdir_proto",
"//proto/tests/dir:proto_source_root_proto",
"//proto/tests/dir:proto_source_root_without_dir_proto",
"//proto/tests/dir:strip_empty_prefix_proto",
"//proto/tests/dir:strip_empty_prefix_without_dir_proto",
"//proto/tests/dir:strip_prefix_proto",
Expand All @@ -89,73 +87,6 @@ proto_library(
],
)

# TODO(yannic): This is incompatible with --incompatible_disable_proto_source_root.
proto_library(
name = "proto_source_root_proto",
srcs = [
"proto_source_root/proto_source_root.proto",
],
proto_source_root = "proto/tests/dir",
visibility = [
"//proto/tests:__subpackages__",
],
)

# TODO(yannic): This is incompatible with --incompatible_disable_proto_source_root.
proto_library(
name = "proto_source_root_import_proto",
srcs = [
"proto_source_root/proto_source_root_import.proto",
],
proto_source_root = "proto/tests/dir",
visibility = [
"//proto/tests:__subpackages__",
],
deps = [
"//proto/tests:add_prefix_proto",
"//proto/tests:add_prefix_with_dir_proto",
"//proto/tests:no_prefix_proto",
"//proto/tests/dir:add_and_strip_empty_prefix_proto",
"//proto/tests/dir:add_and_strip_empty_subdir_prefix_proto",
"//proto/tests/dir:add_and_strip_prefix_proto",
"//proto/tests/dir:add_and_strip_prefix_subdir_proto",
"//proto/tests/dir:proto_source_root_proto",
"//proto/tests/dir:proto_source_root_without_dir_proto",
"//proto/tests/dir:strip_empty_prefix_proto",
"//proto/tests/dir:strip_empty_prefix_without_dir_proto",
"//proto/tests/dir:strip_prefix_proto",
"//proto/tests/dir:strip_prefix_with_dir_proto",
],
)

# TODO(yannic): This is incompatible with --incompatible_disable_proto_source_root.
proto_library(
name = "proto_source_root_import_full_proto",
srcs = [
"proto_source_root/proto_source_root_import_full.proto",
],
proto_source_root = "proto/tests/dir",
visibility = [
"//proto/tests:__subpackages__",
],
deps = [
"//proto/tests/dir:proto_source_root_proto",
"//proto/tests/dir:proto_source_root_without_dir_proto",
],
)

# TODO(yannic): This is incompatible with --incompatible_disable_proto_source_root.
proto_library(
name = "proto_source_root_without_dir_proto",
srcs = [
"proto_source_root_without_dir.proto",
],
proto_source_root = "proto/tests/dir",
visibility = [
"//proto/tests:__subpackages__",
],
)

proto_library(
name = "strip_empty_prefix_proto",
srcs = [
Expand Down Expand Up @@ -206,8 +137,6 @@ proto_library(
"//proto/tests/dir:add_and_strip_empty_subdir_prefix_proto",
"//proto/tests/dir:add_and_strip_prefix_proto",
"//proto/tests/dir:add_and_strip_prefix_subdir_proto",
"//proto/tests/dir:proto_source_root_proto",
"//proto/tests/dir:proto_source_root_without_dir_proto",
"//proto/tests/dir:strip_empty_prefix_proto",
"//proto/tests/dir:strip_empty_prefix_without_dir_proto",
"//proto/tests/dir:strip_prefix_proto",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ import "import_prefix/add_and_strip_empty_prefix.proto";
import "import_prefix/add_and_strip_prefix.proto";
import "import_prefix/add_and_strip_prefix/add_and_strip_empty_subdir_prefix.proto";
import "import_prefix/dir/add_and_strip_prefix_subdir.proto";
import "proto_source_root/proto_source_root.proto";
import "proto_source_root_without_dir.proto";
import "strip_empty_prefix_without_dir.proto";
import "strip_prefix.proto";
import "strip_prefix/strip_empty_prefix.proto";
Expand All @@ -38,10 +36,8 @@ message AddAndStripPrefixImport {
AddAndStripPrefix add_and_strip_prefix = 5;
AddAndStripEmptySubdirPrefix add_and_strip_empty_subdir_prefix = 6;
AddAndStripPrefixSubdir add_and_strip_prefix_subdir = 7;
ProtoSourceRoot proto_source_root = 8;
ProtoSourceRootWithoutDir proto_source_root_without_dir = 9;
StripEmptyPrefixWithoutDir strip_empty_prefix_without_dir = 10;
StripPrefix strip_prefix = 11;
StripEmptyPrefix strip_empty_prefix = 12;
NoPrefix no_prefix = 13;
StripEmptyPrefixWithoutDir strip_empty_prefix_without_dir = 8;
StripPrefix strip_prefix = 9;
StripEmptyPrefix strip_empty_prefix = 10;
NoPrefix no_prefix = 11;
}
21 changes: 0 additions & 21 deletions proto/tests/dir/proto_source_root/proto_source_root.proto

This file was deleted.

47 changes: 0 additions & 47 deletions proto/tests/dir/proto_source_root/proto_source_root_import.proto

This file was deleted.

This file was deleted.

21 changes: 0 additions & 21 deletions proto/tests/dir/proto_source_root_without_dir.proto

This file was deleted.

12 changes: 4 additions & 8 deletions proto/tests/dir/strip_prefix/strip_prefix_import.proto
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ import "import_prefix/add_and_strip_empty_prefix.proto";
import "import_prefix/add_and_strip_prefix.proto";
import "import_prefix/add_and_strip_prefix/add_and_strip_empty_subdir_prefix.proto";
import "import_prefix/dir/add_and_strip_prefix_subdir.proto";
import "proto_source_root/proto_source_root.proto";
import "proto_source_root_without_dir.proto";
import "strip_empty_prefix_without_dir.proto";
import "strip_prefix.proto";
import "strip_prefix/strip_empty_prefix.proto";
Expand All @@ -38,10 +36,8 @@ message StripPrefixImport {
AddAndStripPrefix add_and_strip_prefix = 5;
AddAndStripEmptySubdirPrefix add_and_strip_empty_subdir_prefix = 6;
AddAndStripPrefixSubdir add_and_strip_prefix_subdir = 7;
ProtoSourceRoot proto_source_root = 8;
ProtoSourceRootWithoutDir proto_source_root_without_dir = 9;
StripEmptyPrefixWithoutDir strip_empty_prefix_without_dir = 10;
StripPrefix strip_prefix = 11;
StripEmptyPrefix strip_empty_prefix = 12;
NoPrefix no_prefix = 13;
StripEmptyPrefixWithoutDir strip_empty_prefix_without_dir = 8;
StripPrefix strip_prefix = 9;
StripEmptyPrefix strip_empty_prefix = 10;
NoPrefix no_prefix = 11;
}
16 changes: 5 additions & 11 deletions proto/tests/import_all.proto
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ import "import_prefix/add_and_strip_prefix.proto";
import "import_prefix/add_and_strip_prefix/add_and_strip_empty_subdir_prefix.proto";
import "import_prefix/add_and_strip_prefix_import.proto";
import "import_prefix/dir/add_and_strip_prefix_subdir.proto";
import "proto_source_root/proto_source_root.proto";
import "proto_source_root/proto_source_root_import.proto";
import "proto_source_root_without_dir.proto";
import "strip_empty_prefix_without_dir.proto";
import "strip_prefix.proto";
import "strip_prefix/strip_empty_prefix.proto";
Expand All @@ -46,12 +43,9 @@ message ImportAll {
AddAndStripEmptySubdirPrefix add_and_strip_empty_subdir_prefix = 8;
AddAndStripPrefixImport add_and_strip_prefix_import = 9;
AddAndStripPrefixSubdir add_and_strip_prefix_subdir = 10;
ProtoSourceRoot proto_source_root = 11;
ProtoSourceRootImport proto_source_root_import = 12;
ProtoSourceRootWithoutDir proto_source_root_without_dir = 13;
StripEmptyPrefixWithoutDir strip_empty_prefix_without_dir = 14;
StripPrefix strip_prefix = 15;
StripEmptyPrefix strip_empty_prefix = 16;
StripPrefixImport strip_prefix_import = 17;
NoPrefix no_prefix = 18;
StripEmptyPrefixWithoutDir strip_empty_prefix_without_dir = 11;
StripPrefix strip_prefix = 12;
StripEmptyPrefix strip_empty_prefix = 13;
StripPrefixImport strip_prefix_import = 14;
NoPrefix no_prefix = 15;
}

0 comments on commit a100e6e

Please sign in to comment.