Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjusted quick-xml update #7 #9

Merged
merged 3 commits into from
Oct 4, 2022
Merged

adjusted quick-xml update #7 #9

merged 3 commits into from
Oct 4, 2022

Conversation

hitenkoku
Copy link
Collaborator

@hitenkoku hitenkoku commented Oct 3, 2022 •
edited
Loading

Closes #6

What Changed

  • Updated quick-xml update

refs: omerbenamram/evtx@d08934e

@hitenkoku hitenkoku self-assigned this Oct 3, 2022
YamatoSecurity
YamatoSecurity approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
quick-xml 0.25もいけそうなので、そちらにアップしました。

@hitenkoku hitenkoku merged commit 5b0884d into main Oct 4, 2022
@hitenkoku hitenkoku deleted the 7-add-build-tests-to-github-actions branch October 4, 2022 02:07
@hitenkoku
Copy link
Collaborator Author

ありがとうございました。マージしました

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamatoSecurity YamatoSecurity YamatoSecurity approved these changes

Assignees

@hitenkoku hitenkoku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt CDATA in evtx (compile error in quick-xml >=0.24)
2 participants
@hitenkoku @YamatoSecurity