Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quick-xml 0.37.0 compile error #68

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Oct 30, 2024

What Changed

The following change seems to have caused a change in the type of the Error class returned by the write method.

Evidence

fukusuke@fukusukenoMacBook-Air hayabusa-evtx % cargo update
    Updating crates.io index
     Locking 16 packages to latest compatible versions
    Updating anstream v0.6.15 -> v0.6.17
    Updating anstyle v1.0.8 -> v1.0.9
    Updating anstyle-parse v0.2.5 -> v0.2.6
    Updating anstyle-query v1.1.1 -> v1.1.2
    Updating anstyle-wincon v3.0.4 -> v3.0.6
    Updating anyhow v1.0.90 -> v1.0.91
    Updating colorchoice v1.0.2 -> v1.0.3
    Updating proc-macro2 v1.0.88 -> v1.0.89
    Updating quick-xml v0.36.2 -> v0.37.0
    Updating regex v1.11.0 -> v1.11.1
    Updating rustix v0.38.37 -> v0.38.38
    Updating serde v1.0.210 -> v1.0.214
    Updating serde_derive v1.0.210 -> v1.0.214
    Updating syn v2.0.82 -> v2.0.85
    Updating thiserror v1.0.64 -> v1.0.65
    Updating thiserror-impl v1.0.64 -> v1.0.65
note: pass `--verbose` to see 17 unchanged dependencies behind latest
fukusuke@fukusukenoMacBook-Air hayabusa-evtx % cargo build --release
   Compiling proc-macro2 v1.0.88
   Compiling unicode-ident v1.0.13
   Compiling libc v0.2.161
   Compiling crossbeam-utils v0.8.20
   Compiling encoding_index_tests v0.1.4
   Compiling autocfg v1.4.0
   Compiling serde v1.0.210
   Compiling utf8parse v0.2.2
   Compiling rustix v0.38.37
   Compiling thiserror v1.0.64
   Compiling syn v1.0.109
   Compiling num-traits v0.2.19
   Compiling crossbeam-epoch v0.9.18
   Compiling anstyle-parse v0.2.5
   Compiling quote v1.0.37
   Compiling syn v2.0.82
   Compiling bitflags v2.6.0
   Compiling core-foundation-sys v0.8.7
   Compiling anstyle-query v1.1.1
   Compiling colorchoice v1.0.2
   Compiling anstyle v1.0.8
   Compiling cfg-if v1.0.0
   Compiling memchr v2.7.4
   Compiling is_terminal_polyfill v1.70.1
   Compiling rayon-core v1.12.1
   Compiling serde_json v1.0.132
   Compiling anstream v0.6.15
   Compiling iana-time-zone v0.1.61
   Compiling crossbeam-deque v0.8.5
   Compiling itoa v1.0.11
   Compiling strsim v0.11.1
   Compiling errno v0.3.9
   Compiling anyhow v1.0.90
   Compiling fastrand v2.1.1
   Compiling ryu v1.0.18
   Compiling lazy_static v1.5.0
   Compiling clap_lex v0.7.2
   Compiling unicode-width v0.1.14
   Compiling once_cell v1.20.2
   Compiling clap_builder v4.5.20
   Compiling console v0.15.8
   Compiling encoding-index-simpchinese v1.20141219.5
   Compiling encoding-index-korean v1.20141219.5
   Compiling encoding-index-singlebyte v1.20141219.5
   Compiling encoding-index-tradchinese v1.20141219.5
   Compiling encoding-index-japanese v1.20141219.5
   Compiling tempfile v3.13.0
   Compiling either v1.13.0
   Compiling foldhash v0.1.3
   Compiling byteorder v1.5.0
   Compiling serde_derive v1.0.210
   Compiling thiserror-impl v1.0.64
   Compiling allocator-api2 v0.2.18
   Compiling bitflags v1.3.2
   Compiling zeroize v1.8.1
   Compiling log v0.4.22
   Compiling equivalent v1.0.1
   Compiling shell-words v1.1.0
   Compiling rayon v1.10.0
   Compiling encoding v0.2.33
   Compiling hashbrown v0.15.0
   Compiling num-derive v0.3.3
   Compiling quick-xml v0.36.2
   Compiling crc32fast v1.4.2
   Compiling indoc v2.0.5
   Compiling dialoguer v0.11.0
   Compiling clap v4.5.20
   Compiling chrono v0.4.38
   Compiling winstructs v0.3.2
   Compiling evtx v0.8.10 (/Users/fukusuke/Scripts/Rust/hayabusa-evtx)
    Finished `release` profile [optimized] target(s) in 27.00s
fukusuke@fukusukenoMacBook-Air hayabusa-evtx %  

@fukusuket fukusuket self-assigned this Oct 30, 2024
@fukusuket fukusuket added the bug Something isn't working label Oct 30, 2024
@fukusuket fukusuket marked this pull request as ready for review October 30, 2024 00:58
Copy link
Contributor

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit c8ed9d2 into main Oct 30, 2024
7 checks passed
@YamatoSecurity YamatoSecurity deleted the 67-fix-quick-xml-compile-error branch October 30, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error with quick-xml 0.37.0
2 participants