Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update targetOs to target_os to fix packer errors #46

Merged

Conversation

frightenedmonkey
Copy link
Contributor

The targetOs version of the parameter wasn't usable by packer directly,
and I received an error attempting to use the merged version of the
changes to use the 1.7 packer release. Turns out that when I rebased
onto the windows support, I failed to directly test & ended up failing with
a recurrence of the problem reported in issue 40, and specifically, the
newer problem reported
here

The solution was the same as for the struct tags added in the 1.7 compatibility
upgrade, which was to provide a mapstructure struct tag. Apologies
for missing the new parameter when I rebased.

The targetOs version of the parameter wasn't usable by packer directly,
and I received an error attempting to use the merged version of the
changes to use the 1.7 packer release. Turns out that when I rebased
onto the windows support, I failed to directly test with the same issue
reported in issue 40
[here](YaleUniversity#40 (comment))

I fixed a couple of issues around struct tags when updating the
provisioner to support 1.7; I just happened to miss the new parameter
added with Windows support.
@frightenedmonkey
Copy link
Contributor Author

I did test a build with these changes locally to make sure it all worked & it's 💯

@Lirt
Copy link

Lirt commented Mar 11, 2021

I can test to double check if you want.

@frightenedmonkey
Copy link
Contributor Author

@Lirt Please! I'd like to make sure it solves the issue for everyone.

@fishnix
Copy link
Contributor

fishnix commented Mar 11, 2021

I didn't test with that parameter. @Lirt once you have a chance to test it, i can merge. Thanks!

@Lirt
Copy link

Lirt commented Mar 11, 2021

When I try to build using the source fork+branch frightenedmonkey:fix-another-struct-tag I get build errors:

$ go build -v -o packer-provisioner-goss-ova
go: github.com/hashicorp/[email protected] requires
	github.com/hashicorp/[email protected]: invalid version: unknown revision aef4ced967ec

I tried to bump packer-plugin-sdk to all available versions but all of them fail. I tried to build the scaffolding project https://github.com/hashicorp/packer-plugin-scaffolding but it fails as well.

Shall we report it to packer slack or am I doing something wrong?

@frightenedmonkey
Copy link
Contributor Author

@Lirt weird, I haven't had any build issues. For clarity, I'm building it locally & I also have a container image where I'm building that branch from source in a CI build—that CI build is going to re-resolve all dependencies and download them at build time.

I also went and looked, and I see that SHA in the packer repository hashicorp/packer@aef4ced967ec

I'm not sure what else to troubleshoot at the moment.

@Lirt
Copy link

Lirt commented Mar 11, 2021

That will be my local issue. Sorry I will try as soon as I fix it.

@Lirt
Copy link

Lirt commented Mar 11, 2021

Ok I fixed my issue and the PR works well in my environment. Thank you.

@fishnix fishnix merged commit e0ae859 into YaleUniversity:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants