ac.partial.render() throws error for handlebar custom helper

[jithine]

I have a handlebar helper which is added via

 ac.helpers.set('generateSelect', generateSelectHelper);

When running

148             ac.partial.render(newData, 'new-tasks', function (err, html) {
149                 Y.log(err);
150                 Y.log(html);
151                 ac.done(html);
152             });

I get this error

Uncaught Error: Could not find property 'generateSelect'

Content of new-tasks.hb.html

    1 <div id="{{mojit_view_id}}">
    2     {{#each data}}
    3         {{> task }}
    4     {{/each}}
    5 </div>

Contents of ./partials/task.hb.html

...
  4             <div class="content-row task-data pure-g">
  5                 <div class="drop-down-container pure-u-1-6">
  6                     {{{generateSelect tasks "task"}}}
  7                 </div>
  8            </div>
...

On an additional note ac.partial.render() does not accept a handle bar view partial located inside partials/ folder which restricts it's use. Eg:

 ac.partial.render(newData, './partials/task', ...

Gives an error saying cannot find ./partials/task'

[caridy]

Hey, this is a limitation of handlebars and not an issue in mojito. Handlebars will not propagate context from parent to a partial, that's why all functions and data available at the regular template will not be available into the partial unless you use ../something to reference to the parent context. Here is the discussion about the actual fix in the next version of handlebars, which includes some of the workaround:

handlebars-lang/handlebars.js#182

[jithine]

@caridy But it does work when I use ac.done() and the associated view uses the partial. ie instead of ac.partial.render () this works

150             ac.done({data : newData }, {
151                 view :  {
152                     name: "new-tasks"
153                 }
154             });

Then what is the purpose of ac.partial ? From the naming it suggests that it's for manipulating partials but it cannot load html inside partials directory. Documentation - http://developer.yahoo.com/cocktails/mojito/api/classes/Partial.common.html#method_render - says for ac.partial.render() view has to be views folder, which makes me conclude that ac.partial is not for handlebar partials.

My use-case if to instantiate this partial with new data, like in YUI template - http://yuilibrary.com/yui/docs/template/

[caridy]

@jithin1987 yes, now I understand what you want to do. First of all: ac.partial has nothing to with handlebars partials, it is a partial rendering as opposite to ac.done() which does a full rendering releasing the control from the controller. Basically, when calling ac.partial.render(data, 'new-tasks', callback), it is equivalent to call ac.done(data, { view: { name: 'new-tasts' } }), as you described, but with the ability to control the output before releasing the control.

Anyway, there is a bug in line 66 in the partial addon where the second argument should be just instance instead of instance.type:
https://github.com/yahoo/mojito/blob/develop/lib/app/addons/ac/partial.common.js#L66

Feel free to send a PR or wait for us to get to that. /cc @lzhan

[jithine]

@caridy Thank you very much for clarifying. One doubt I still have with partials is that, in Mojito is it possible to instantiate a view partial with data and render it, without having to include it in a view first ? ie in view.name can I use partial/task instead of using new-tasks which includes the partial task

[caridy]

@jithin1987 yes, path/to/filename within the views folder could be used to call ac.done() but also ac.partial.render(). In this case, it is ok to call partials/task, if that doesn't work for you, it might be a bug.

[lzhan]

According to Mojito API: http://developer.yahoo.com/cocktails/mojito/api/classes/Partial.common.html#method_render, only putting partial view file directly under views dir is supported. I checked ac.partial.render(newData, 'task', ...) works fine. ac.partial.render(newData, './partials/task', ...) is not supported currently.

[lzhan]

Just verified: ac.partial.render(newData, 'partials/task', ...) should works (don't use './partials/task'). Plz try.

[caridy]

@jithin1987 any update on this?

[jithine]

@caridy @lzhan This still does not work for me.

199                 ac.partial.render(
200                     currentData.comments,
201                     'partials/message',
202                     function(error, result) {
203                         Y.log(error);
204                         Y.log(result);
205                         ac.done(result);
206                     }
207                 );

Log Output

debug: View "partials/message" not found
debug: undefined

I do have this file partials/message.hb.html
My Mojito version is 0.7.5

[jithine]

@caridy @lzhan

I think I figured out what is happening, if I use any path other than partials it works.
Eg: partial/message.hb.html works. But I wanted to use partials because this way I can make my index.html include the partial in it and based on a user action I can refresh that part by using partial.render()

So my options here are to make this part of my mojit a child mojit or use a different view to have my content rendered there.

[jithine]

And the easiest fix here for me is to do cp -r partials/ partial or ln -s partials partial

[lzhan]

@jithin1987 @caridy : I just checked. partials/ doesn't work. I will check what is going on there.

[caridy]

Yes, I remember I added a rule to treat files under partials/ as a different kind of views, therefore they are not available has views to avoid the duplication specially in Shaker, where all files are going to be aggregated. We need to decide what to do in this case. My initial thoughts are:

• keep the current schema
• add a rule in the template lookup routine to deal with partials/* if they really want to render an individual partial as a regular template.

I will sync up with the team later today and we can make a decision on this. @jithin1987 thanks again for the help to get the to bottom of this.

[lzhan]

Fix is available in mojito 0.8.3.