This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
#11 customizable fonts #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
CLA is valid! |
|
@PLJNS I sent a PR to your fork. Please check it out. |
Trim a little for fitting code convention
| @@ -419,7 +419,7 @@ - (void)updateViewWithCollectionItem:(NSDictionary *)collectionItem | |||
|
|
|||
| UIButton *albumButton = [UIButton buttonWithType:UIButtonTypeSystem]; | |||
| albumButton.tintColor = self.theme.titleLabelTextColor; | |||
| albumButton.titleLabel.font = [UIFont systemFontOfSize:18.0]; | |||
| albumButton.titleLabel.font = self.theme.titleLabelFont ?: [UIFont systemFontOfSize:18.0]; | |||
There was a problem hiding this comment.
@PLJNS I forgot to change this line. Could you help me to change this line into
albumButton.titleLabel.font = self.theme.titleLabelFont;
? Because theme.titleLabelFont is non-null property, we don't need to check it here.
|
@PLJNS Looks good. I'll merge it after travis passes this build. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users of this framework to customize the fonts using the theme API, for instance: