fix: shell escaping on non windows platforms

YOU54F · May 28, 2024 · d5ec9ea · d5ec9ea
1 parent 3515c11
commit d5ec9ea
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 7 deletions.
diff --git a/bin/pact-broker.ts b/bin/pact-broker.ts
@@ -3,12 +3,14 @@
 import childProcess = require('child_process');
 import rubyStandalone from '../src/pact-standalone';
 
+const isWindows = process.platform === 'win32'
+const opts = isWindows ? { shell: true } : {}
 const { error, status } = childProcess.spawnSync(
   rubyStandalone.brokerFullPath,
   process.argv.slice(2),
   {
     stdio: 'inherit',
-    shell: true,
+    ...opts
   }
 );
 if (error) throw error;

diff --git a/bin/pact-message.ts b/bin/pact-message.ts
@@ -3,12 +3,14 @@
 import childProcess = require('child_process');
 import rubyStandalone from '../src/pact-standalone';
 
+const isWindows = process.platform === 'win32'
+const opts = isWindows ? { shell: true } : {}
 const { error, status } = childProcess.spawnSync(
   rubyStandalone.messageFullPath,
   process.argv.slice(2),
   {
     stdio: 'inherit',
-    shell: true,
+    ...opts
   }
 );
 if (error) throw error;

diff --git a/bin/pact-mock-service.ts b/bin/pact-mock-service.ts
@@ -3,12 +3,14 @@
 import childProcess = require('child_process');
 import rubyStandalone from '../src/pact-standalone';
 
+const isWindows = process.platform === 'win32'
+const opts = isWindows ? { shell: true } : {}
 const { error, status } = childProcess.spawnSync(
   rubyStandalone.mockServiceFullPath,
   process.argv.slice(2),
   {
     stdio: 'inherit',
-    shell: true,
+    ...opts
   }
 );
 if (error) throw error;

diff --git a/bin/pact-provider-verifier.ts b/bin/pact-provider-verifier.ts
@@ -3,12 +3,14 @@
 import childProcess = require('child_process');
 import rubyStandalone from '../src/pact-standalone';
 
+const isWindows = process.platform === 'win32'
+const opts = isWindows ? { shell: true } : {}
 const { error, status } = childProcess.spawnSync(
   rubyStandalone.verifierFullPath,
   process.argv.slice(2),
   {
     stdio: 'inherit',
-    shell: true,
+    ...opts
   }
 );
 if (error) throw error;

diff --git a/bin/pact-stub-service.ts b/bin/pact-stub-service.ts
@@ -3,12 +3,14 @@
 import childProcess = require('child_process');
 import rubyStandalone from '../src/pact-standalone';
 
+const isWindows = process.platform === 'win32'
+const opts = isWindows ? { shell: true } : {}
 const { error, status } = childProcess.spawnSync(
   rubyStandalone.stubFullPath,
   process.argv.slice(2),
   {
     stdio: 'inherit',
-    shell: true,
+    ...opts
   }
 );
 if (error) throw error;

diff --git a/bin/pact.ts b/bin/pact.ts
@@ -3,12 +3,14 @@
 import childProcess = require('child_process');
 import rubyStandalone from '../src/pact-standalone';
 
+const isWindows = process.platform === 'win32'
+const opts = isWindows ? { shell: true } : {}
 const { error, status } = childProcess.spawnSync(
   rubyStandalone.pactFullPath,
   process.argv.slice(2),
   {
     stdio: 'inherit',
-    shell: true,
+    ...opts
   }
 );
 if (error) throw error;

diff --git a/bin/pactflow.ts b/bin/pactflow.ts
@@ -3,12 +3,14 @@
 import childProcess = require('child_process');
 import rubyStandalone from '../src/pact-standalone';
 
+const isWindows = process.platform === 'win32'
+const opts = isWindows ? { shell: true } : {}
 const { error, status } = childProcess.spawnSync(
   rubyStandalone.pactflowFullPath,
   process.argv.slice(2),
   {
     stdio: 'inherit',
-    shell: true,
+    ...opts
   }
 );
 if (error) throw error;