compilation error gcc 8.5 with [-Werror=suggest-override] (gabime#3158)

Y-way · Aug 27, 2024 · a3a0c9d · a3a0c9d
1 parent 5ebfc92
commit a3a0c9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/include/spdlog/sinks/ansicolor_sink.h b/include/spdlog/sinks/ansicolor_sink.h
@@ -40,7 +40,7 @@ class ansicolor_sink : public sink {
 
     void log(const details::log_msg &msg) override;
     void flush() override;
-    void set_pattern(const std::string &pattern) final;
+    void set_pattern(const std::string &pattern) final override;
     void set_formatter(std::unique_ptr<spdlog::formatter> sink_formatter) override;
 
     // Formatting codes

diff --git a/include/spdlog/sinks/base_sink.h b/include/spdlog/sinks/base_sink.h
@@ -28,10 +28,10 @@ class SPDLOG_API base_sink : public sink {
     base_sink &operator=(const base_sink &) = delete;
     base_sink &operator=(base_sink &&) = delete;
 
-    void log(const details::log_msg &msg) final;
-    void flush() final;
-    void set_pattern(const std::string &pattern) final;
-    void set_formatter(std::unique_ptr<spdlog::formatter> sink_formatter) final;
+    void log(const details::log_msg &msg) final override;
+    void flush() final override;
+    void set_pattern(const std::string &pattern) final override;
+    void set_formatter(std::unique_ptr<spdlog::formatter> sink_formatter) final override;
 
 protected:
     // sink formatter