feat: feed end indicator (2) #385
Conversation
|
@sevonj is attempting to deploy a commit to the Xylight's projects Team on Vercel. A member of the Team first needs to authorize it. |
| {#if feedData.community_name} | ||
| You have reached the end of {feedData.community_name}. | ||
| {:else} | ||
| You have reached the end of the feed. | ||
| {/if} |
There was a problem hiding this comment.
These strings are now separate because I already know that trying to work one to fit both would be a pain in some languages.
There was a problem hiding this comment.
You could make a string like this:
"endFeed": "You have reached the end of {feed}",
"feed": "The feed"
and then in the code:
$t('endFeed', { feed: feedData.community_name ?? $t('feed').toLowercase() }There was a problem hiding this comment.
I have to think through the logic so I can make it grammatically correct in the Finnish translation. The language uses cases everywhere, so I have to restructure the sentence to work myself out of the need to change the case of community_name.
Maybe I can put the entire sentence inside a check like {{feed;the feed:{{feed}}_sentence; default:community_sentence {{feed}};}}
sevonj
force-pushed
the
feat-feed-end-indicator2
branch
from
f80a882 to
f561670
Compare
| @@ -183,7 +183,8 @@ | |||
| "routes": { | |||
| "frontpage": { | |||
| "title": "Frontpage", | |||
| "footer": "{{users:number}} active {{users; 1:user; default:users;}}" | |||
| "footer": "{{users:number}} active {{users; 1:user; default:users;}}", | |||
| "endFeed": "You have reached the end of {{community_name; undefined:the feed.; default:{{community_name}}.}}" | |||
There was a problem hiding this comment.
This is the cleanest way I could come up with.
I put it under routes.frontpage since that's where the old footer is too.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I just added a scroll to top button and made it so it wouldn't overflow with the scroll button. |
|
Thanks for your contribution! |
Second attempt at #369
Still needs to use translations, maybe rephrase it too.
I omitted the scroll to top button as it did not work.